Thread: [pygccxml-development] [FT] recent changes
Brought to you by:
mbaas,
roman_yakovenko
From: Roman Y. <rom...@gm...> - 2006-09-20 18:06:53
|
Hi. Few comments on committed code: 1. rename gil_state_t to gil_controller_t In my opinion it is better describes what we are doing 2. to put gil_controller_t under pyplusplus::threading namespace pyplusplus is top level namespace, like boost. Every functionality should belong to it's own namespace. 3. creator_t: self.__extmodule.adopt_creator( code_creators.include_t( code_repository.gil_state.file_name ) , self.__extmodule.first_include_index() + 1) Is there is a reason why do you want to put your file to be the second one? If not, I think you can swith to module_t.adopt_include method -- Roman Yakovenko C++ Python language binding http://www.language-binding.net/ |
From: Roman Y. <rom...@gm...> - 2006-09-20 18:08:36
|
On 9/20/06, Roman Yakovenko <rom...@gm...> wrote: Sorry I push wrong button to earlier I'd like to say that I propose next changes: > Hi. Few comments on committed code: > > 1. rename gil_state_t to gil_controller_t > In my opinion it is better describes what we are doing I propose to rename ..., to put ... > 2. to put gil_controller_t under pyplusplus::threading namespace > pyplusplus is top level namespace, like boost. Every functionality should > belong to it's own namespace. > > 3. creator_t: > self.__extmodule.adopt_creator( code_creators.include_t( > code_repository.gil_state.file_name ) > , > self.__extmodule.first_include_index() + 1) > Is there is a reason why do you want to put your file to be the second one? > If not, I think you can swith to module_t.adopt_include method > > > -- > Roman Yakovenko > C++ Python language binding > http://www.language-binding.net/ > -- Roman Yakovenko C++ Python language binding http://www.language-binding.net/ |
From: Allen B. <al...@vr...> - 2006-09-20 18:12:38
|
Roman Yakovenko wrote: >Hi. Few comments on committed code: > >1. rename gil_state_t to gil_controller_t > In my opinion it is better describes what we are doing > > Technically the pattern it implements is a guard, so I would suggest gil_guard_t if it was to be renamed. -Allen >2. to put gil_controller_t under pyplusplus::threading namespace > pyplusplus is top level namespace, like boost. Every functionality should > belong to it's own namespace. > >3. creator_t: > self.__extmodule.adopt_creator( code_creators.include_t( >code_repository.gil_state.file_name ) > , >self.__extmodule.first_include_index() + 1) > Is there is a reason why do you want to put your file to be the second one? > If not, I think you can swith to module_t.adopt_include method > > > > |
From: Roman Y. <rom...@gm...> - 2006-09-20 18:15:08
|
On 9/20/06, Allen Bierbaum <al...@vr...> wrote: > Roman Yakovenko wrote: > > >Hi. Few comments on committed code: > > > >1. rename gil_state_t to gil_controller_t > > In my opinion it is better describes what we are doing > > > > > Technically the pattern it implements is a guard, so I would suggest > gil_guard_t if it was to be renamed. Another valid option :-) -- Roman Yakovenko C++ Python language binding http://www.language-binding.net/ |
From: Matthias B. <ba...@ir...> - 2006-09-21 09:58:34
|
Allen Bierbaum wrote: > Roman Yakovenko wrote: > >> Hi. Few comments on committed code: >> >> 1. rename gil_state_t to gil_controller_t >> In my opinion it is better describes what we are doing >> >> > Technically the pattern it implements is a guard, so I would suggest > gil_guard_t if it was to be renamed. I was calling it gil_state_t because it wraps the PyGILState_STATE type but gil_guard_t is fine with me as well. I've just committed the modification. - Matthias - |
From: Brian O. <bob...@ya...> - 2006-09-21 03:25:58
|
any binaries yet? __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com |
From: Roman Y. <rom...@gm...> - 2006-09-21 05:05:51
|
On 9/21/06, Brian OBrien <bob...@ya...> wrote: > any binaries yet? Unfortunately not. I don't have access to the platform. -- Roman Yakovenko C++ Python language binding http://www.language-binding.net/ |
From: Matthias B. <ba...@ir...> - 2006-09-21 10:14:23
|
Brian OBrien wrote: > any binaries yet? Just out of curiosity, why does OSX require a binary? Py++ (and pygccxml) are pure Python packages, so couldn't you just install them with "python setup.py install"? - Matthias - |
From: Matthias B. <ba...@ir...> - 2006-09-21 10:02:26
|
Roman Yakovenko wrote: > 1. rename gil_state_t to gil_controller_t Done (I renamed it to gil_guard_t as was suggested and approved in another mail). > 2. to put gil_controller_t under pyplusplus::threading namespace > pyplusplus is top level namespace, like boost. Every functionality should > belong to it's own namespace. Done. > 3. creator_t: > self.__extmodule.adopt_creator( code_creators.include_t( > code_repository.gil_state.file_name ) > , > self.__extmodule.first_include_index() + 1) > Is there is a reason why do you want to put your file to be the second one? > If not, I think you can swith to module_t.adopt_include method I was just copying this line from another place in Py++, I don't need it it at the second position. I noticed that there is even an add_include() method which is what I'm using now. - Matthias - |
From: Brian O. <bob...@ya...> - 2006-09-26 14:42:59
|
If I gave you an account on my system... Do you think you could help to get this running? Is this even the right group to be dicussing py++ __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com |
From: Roman Y. <rom...@gm...> - 2006-09-26 18:26:00
|
On 9/26/06, Brian OBrien <bob...@ya...> wrote: > If I gave you an account on my system... Do you think > you could help to get this running? To tell you the true I never used MAC computer. More over I fill better when I use Windows than Linux. So, sorry I can help you. May be you can ask for help at Boost.Python mailing list. I am sure there are few MAC users there. > Is this even the > right group to be dicussing py++ Yes this is a right group to discuss Py++, actually this is the only thing we do in this group :-) -- Roman Yakovenko C++ Python language binding http://www.language-binding.net/ |
From: Darren G. <ga...@MI...> - 2006-09-28 15:23:14
|
Hmm.. I think that this message got bounced. Anyhow, I can confirm that installation of Py++ from the SVN works as expected in the normal way. pygccxml runs and passes all unittests. I haven't gotten the unittests in pyplusplus to run since I don't have Scons setup quite right... But I can run the example programs and have gotten my own code to work. So, the instructions are very simple... get fink, so you can get "cmake" so you can install gccxml.... (this is the hard part.... but if you are desperate, I could make a universal binary installer for you....) get boost... I downloaded the binary boost-jam and then made boost from the source. This won't work if you have an intel mac though. You'll have to build boost-jam as well. (The latest release... not the cvs). get Py++ and do the "python setup.py install" thing. Cheers, Darren. On Sep 26, 2006, at 6:42 PM, Darren Garnier wrote: > Hi all, > > Long time lurker... first time poster. I have used Py++ on the > mac. I used v. 0.80 from back in June and had minimal problems > "porting" it to the mac. (Like 2 lines that I sent a patch to > Roman with). I used it for a quick project and haven't gotten > back to trying it since all the numerous improvements. > > Anyway, its just to say, if it doesn't just work the python setup > install way, it won't be hard to fix any issues. If I get a chance > to update, I'll send specific instructions... in the meantime > "Courage". > > Darren. > Levitated Dipole Experiment > http://www.psfc.mit.edu/ldx/ > > > On Sep 26, 2006, at 2:25 PM, Roman Yakovenko wrote: > >> On 9/26/06, Brian OBrien <bob...@ya...> wrote: >>> If I gave you an account on my system... Do you think >>> you could help to get this running? >> >> To tell you the true I never used MAC computer. More over I fill >> better when >> I use Windows than Linux. So, sorry I can help you. May be you can >> ask for >> help at Boost.Python mailing list. I am sure there are few MAC >> users there. >> >>> Is this even the >>> right group to be dicussing py++ >> >> Yes this is a right group to discuss Py++, actually this is the >> only thing we do >> in this group :-) >> >> -- >> Roman Yakovenko >> C++ Python language binding >> http://www.language-binding.net/ >> >> --------------------------------------------------------------------- >> ---- >> Take Surveys. Earn Cash. Influence the Future of IT >> Join SourceForge.net's Techsay panel and you'll get the chance to >> share your >> opinions on IT & business topics through brief surveys -- and earn >> cash >> http://www.techsay.com/default.php? >> page=join.php&p=sourceforge&CID=DEVDEV >> _______________________________________________ >> pygccxml-development mailing list >> pyg...@li... >> https://lists.sourceforge.net/lists/listinfo/pygccxml-development > |