|
From: Matthias B. <ba...@ir...> - 2006-08-24 12:00:11
|
al...@us... wrote: > Revision: 451 > Author: allenb > Date: 2006-08-23 16:30:51 -0700 (Wed, 23 Aug 2006) > ViewCVS: http://svn.sourceforge.net/pygccxml/?rev=451&view=rev > > Log Message: > ----------- > I *think* this fixes a bug. > > As far as I can tell with Python 2.4 atleast bool([False,True]) is still true so the logic of this test was not working. > > Please review this commit to verify that I have fixed something though. > > Modified Paths: > -------------- > pygccxml_dev/pygccxml/declarations/mdecl_wrapper.py > Modified: pygccxml_dev/pygccxml/declarations/mdecl_wrapper.py > [...] > invalid_decls = filter( lambda d: not hasattr( d, name ), self.decls ) > - if invalid_decls: > + if False in invalid_decls: > raise RuntimeError( "Not all declarations have '%s' attribute." % name ) This doesn't look like a fix to me.... (what had to be fixed here anyway?). The previous 'if' statement was equivalent to if len(invalid_decls)!=0: ... which looked all right to me (note that the previous line uses "filter", not "map"). The new 'if' statement checks if the list contains the value "False" which I don't think will ever happen. - Matthias - |
|
From: Roman Y. <rom...@gm...> - 2006-08-27 17:34:34
|
On 8/27/06, Matthias Baas <ba...@ir...> wrote:
> Roman Yakovenko wrote:
> > It could be nice if you and Matthias could run unit tests on regular basis.
>
> What additional configuration is required to run the unit tests? I
> always get an error 'include path "" should exists or to be a valid
> directory name.' whenever I run a test.
There are 3 files you should add you settings in:
pygccxml:
unittests/autoconfig.py
Py++:
pyplusplus_dev/ environment.py
pyplusplus_dev/unittests/autoconfig.py
You will have to in scons.
Also both tests should be run, when pwd is relevant unit tests directory.
Let me know if you need more help with this.
--
Roman Yakovenko
C++ Python language binding
http://www.language-binding.net/
|
|
From: Allen B. <al...@vr...> - 2006-08-27 18:52:04
|
Matthias: A word of warning, the most common problem I find with the settings in this file is that I often get conflicts when I update. I haven't tried to track it down and make it more conflict free, but it is something to watch for. -Allen Roman Yakovenko wrote: >On 8/27/06, Matthias Baas <ba...@ir...> wrote: > > >>Roman Yakovenko wrote: >> >> >>>It could be nice if you and Matthias could run unit tests on regular basis. >>> >>> >>What additional configuration is required to run the unit tests? I >>always get an error 'include path "" should exists or to be a valid >>directory name.' whenever I run a test. >> >> > >There are 3 files you should add you settings in: >pygccxml: > unittests/autoconfig.py >Py++: > pyplusplus_dev/ environment.py > pyplusplus_dev/unittests/autoconfig.py > > You will have to in scons. > >Also both tests should be run, when pwd is relevant unit tests directory. >Let me know if you need more help with this. > > > |
|
From: Roman Y. <rom...@gm...> - 2006-08-27 18:59:51
|
On 8/27/06, Allen Bierbaum <al...@vr...> wrote: > Matthias: > > A word of warning, the most common problem I find with the settings in > this file is that I often get conflicts when I update. I haven't tried > to track it down and make it more conflict free, but it is something to > watch for. I re-factored those files in a such way, that will allow you and Matthias to add and commit your settings. -- Roman Yakovenko C++ Python language binding http://www.language-binding.net/ |
|
From: Matthias B. <ba...@ir...> - 2006-08-28 14:16:03
|
Roman Yakovenko wrote: >> What additional configuration is required to run the unit tests? I >> always get an error 'include path "" should exists or to be a valid >> directory name.' whenever I run a test. > > There are 3 files you should add you settings in: > pygccxml: > unittests/autoconfig.py > Py++: > pyplusplus_dev/ environment.py > pyplusplus_dev/unittests/autoconfig.py All right, I didn't notice the file environment.py. I added my paths to that file and now it seems to work. Here are a few comments on the setup: - I made a small change to autoconfig.py so that the paths in environment.py can use native backslashes on Windows. - Shouldn't the name of the Boost.Python lib also be in environment.py? I take it this file contains all the user/platform dependent setting whereas autoconfig.py is a fixed file. In my case, I had to change the name in autoconfig.py. - I think the test for gccxml.executable is too strict. The script aborts when it cannot find a file that is specified in this variable. This forced me to specify an absolute path which wouldn't have been necessary because I have gccxml in my PATH. - When I run test_all.py I get 4 failures: [I don't see the first failure as the buffer of the DOS box is too small] ERROR: test (operators_tester.tester_t) ERROR: test (indexing_suites2_tester.tester_t) ERROR: test (no_init_tester.tester_t) Is that ok? (well, I know it's not ok, but I mean, do you get those, too?) Do the tests run on Windows properly anyway? (I already had problems with gccxml on Windows before) - Matthias - |
|
From: Roman Y. <rom...@gm...> - 2006-08-28 16:47:17
|
On 8/28/06, Matthias Baas <ba...@ir...> wrote: > > Here are a few comments on the setup: > > - I made a small change to autoconfig.py so that the paths in > environment.py can use native backslashes on Windows. Thanks > - Shouldn't the name of the Boost.Python lib also be in environment.py? > I take it this file contains all the user/platform dependent setting > whereas autoconfig.py is a fixed file. In my case, I had to change the > name in autoconfig.py. Yes, it could be there > - I think the test for gccxml.executable is too strict. The script > aborts when it cannot find a file that is specified in this variable. > This forced me to specify an absolute path which wouldn't have been > necessary because I have gccxml in my PATH. You can change it for your user. I prefer to see full paths. It is easier for me to setup new environment. > - When I run test_all.py I get 4 failures: > > [I don't see the first failure as the buffer of the DOS box is too small] > ERROR: test (operators_tester.tester_t) Can you send the error? > ERROR: test (indexing_suites2_tester.tester_t) Try to add indexing suite 2. You will find instructions in pyplusplus_dev/indexing_suite_v2 > ERROR: test (no_init_tester.tester_t) I still work on it. -- Roman Yakovenko C++ Python language binding http://www.language-binding.net/ |
|
From: Matthias B. <ba...@ir...> - 2006-08-29 07:09:56
|
Roman Yakovenko wrote:
>> ERROR: test (operators_tester.tester_t)
>
> Can you send the error?
gccxml (0.6.0) produces errors on a Boost header which look like this:
gccxml_runtime_error_t: Error occured while running GCC-XML: In file
included from
C:/Programme/Programmieren/boost/include/boost-1_33_1/boost/type_traits/is_arithmetic.hpp:12,
from
C:/Programme/Programmieren/boost/include/boost-1_33_1/boost/type_traits/arithmetic_traits.hpp:14,
from
C:/Programme/Programmieren/boost/include/boost-1_33_1/boost/detail/ob_call_traits.hpp:27,
from
C:/Programme/Programmieren/boost/include/boost-1_33_1/boost/call_traits.hpp:19,
from
C:/Programme/Programmieren/boost/include/boost-1_33_1/boost/rational.hpp:48,
from
D:/home/baas/Projekte/pyplusplus/pyplusplus_dev/unittests/data/operators_to_be_exported.hpp:9:
C:/Programme/Programmieren/boost/include/boost-1_33_1/boost/type_traits/is_integral.hpp:47:
error: syntax
error before `>' token
C:/Programme/Programmieren/boost/include/boost-1_33_1/boost/type_traits/is_integral.hpp:47:
error: syntax
error before `>' token
C:/Programme/Programmieren/boost/include/boost-1_33_1/boost/type_traits/is_integral.hpp:47:
error: syntax
error before `;' token
C:/Programme/Programmieren/boost/include/boost-1_33_1/boost/type_traits/is_integral.hpp:47:
error: `
friend' can only be specified inside a class
.
.
.
.
.
C:/Programme/Programmieren/boost/include/boost-1_33_1/boost/type_traits/is_integral.hpp:48:
internal compiler error: Segmentation
fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
So it doesn't look like this is an error in Py++.
- Matthias -
|
|
From: Roman Y. <rom...@gm...> - 2006-08-29 07:17:44
|
On 8/29/06, Matthias Baas <ba...@ir...> wrote: > Roman Yakovenko wrote: > >> ERROR: test (operators_tester.tester_t) > > > > Can you send the error? > > gccxml (0.6.0) produces errors on a Boost header which look like this: > ... > So it doesn't look like this is an error in Py++. It was very convenient to reuse rational library to test operators support. May be I should change it. Anyway, if you want you can disable this test for your environment. -- Roman Yakovenko C++ Python language binding http://www.language-binding.net/ |
|
From: Allen B. <al...@th...> - 2006-08-24 12:50:16
|
> al...@us... wrote: >> Revision: 451 >> Author: allenb >> Date: 2006-08-23 16:30:51 -0700 (Wed, 23 Aug 2006) >> ViewCVS: http://svn.sourceforge.net/pygccxml/?rev=3D451&view=3Drev >> >> Log Message: >> ----------- >> I *think* this fixes a bug. >> >> As far as I can tell with Python 2.4 atleast bool([False,True]) is sti= ll >> true so the logic of this test was not working. >> >> Please review this commit to verify that I have fixed something though= . >> >> Modified Paths: >> -------------- >> pygccxml_dev/pygccxml/declarations/mdecl_wrapper.py >> Modified: pygccxml_dev/pygccxml/declarations/mdecl_wrapper.py >> [...] >> invalid_decls =3D filter( lambda d: not hasattr( d, name ), >> self.decls ) >> - if invalid_decls: >> + if False in invalid_decls: >> raise RuntimeError( "Not all declarations have '%s' >> attribute." % name ) > > This doesn't look like a fix to me.... (what had to be fixed here > anyway?). > > The previous 'if' statement was equivalent to > > if len(invalid_decls)!=3D0: > ... > > which looked all right to me (note that the previous line uses "filter"= , > not "map"). You are right. I missed that it was a call to filter. Somehow my brain translated that to "map". My bad. :( -Allen > > The new 'if' statement checks if the list contains the value "False" > which I don't think will ever happen. > > > - Matthias - > > -----------------------------------------------------------------------= -- > Using Tomcat but need to do more? Need to support web services, securit= y? > Get stuff done quickly with pre-integrated technology to make your job > easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geron= imo > http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat= =3D121642 > _______________________________________________ > pygccxml-development mailing list > pyg...@li... > https://lists.sourceforge.net/lists/listinfo/pygccxml-development > > |
|
From: Roman Y. <rom...@gm...> - 2006-08-24 17:58:23
|
On 8/24/06, Allen Bierbaum <al...@th...> wrote: > > You are right. I missed that it was a call to filter. Somehow my brain > translated that to "map". My bad. :( It is okay to introduce error, but it is not okay to commit such ( any ) change without running unit tests. Py++ unit tests failed! Try locally to modify the code and run mdecl_wrapper_tester.py. It could be nice if you and Matthias could run unit tests on regular basis. It is very easy to add new environment to the unit tests scripts. -- Roman Yakovenko C++ Python language binding http://www.language-binding.net/ |
|
From: Matthias B. <ba...@ir...> - 2006-08-27 14:01:21
|
Roman Yakovenko wrote: > It could be nice if you and Matthias could run unit tests on regular basis. What additional configuration is required to run the unit tests? I always get an error 'include path "" should exists or to be a valid directory name.' whenever I run a test. - Matthias - |
