Re: [pygccxml-development] FT -subst_t

[Roman Y. <rom...@gm...>]

On 10/11/06, Matthias Baas <ba...@ir...> wrote:
> Roman Yakovenko wrote:
> >> > I propose to delete subst_t class. Main reason:
> >> > Method substitute defines some logic, according to which this it
> >> decides how to
> >> > indent the code. This is just wrong. code_manager_t class understands
> >> > the meaning of
> >> > the variables, so it is its respocibility to indent the code. Without
> >> > subsitute method this class is pretty useless.
> >>
> >> This proposal doesn't mention how to get back the actual functionality
> >> after removing subst_t. So I take it you suggest to move the
> >> substitute() method into the code_manager_t class?
> >
> > Yes. code_manager_t class understands the variables, so it is its
> > responsibility
> > to indent them.
>
> Well, personally I don't see any advantage or benefit of doing this
> change as the resulting code will behave just the same as before

It makes the difference what class formats the code: the one that actually
understands the code, or another, which uses some tricky logic, that envolves
parsing and using regular expression.

> The implementations would be more or less equivalent.

No.

> So why spending precious time modifying
> internal code that works already? I think we've already wasted too much
> time discussing this detail anyway, so as it obviously has a much higher
> importance to you I'd simply suggest you go ahead with the modification.
> As long as the package works as before I don't mind how the internals
> are implemented.

Okey.

-- 
Roman Yakovenko
C++ Python language binding
http://www.language-binding.net/