Re: [pygccxml-development] FT -subst_t

[Matthias B. <ba...@ir...>]

Roman Yakovenko wrote:
>> > I propose to delete subst_t class. Main reason:
>> > Method substitute defines some logic, according to which this it 
>> decides how to
>> > indent the code. This is just wrong. code_manager_t class understands
>> > the meaning of
>> > the variables, so it is its respocibility to indent the code. Without
>> > subsitute method this class is pretty useless.
>>
>> This proposal doesn't mention how to get back the actual functionality
>> after removing subst_t. So I take it you suggest to move the
>> substitute() method into the code_manager_t class?
> 
> Yes. code_manager_t class understands the variables, so it is its 
> responsibility
> to indent them.

Well, personally I don't see any advantage or benefit of doing this 
change as the resulting code will behave just the same as before and as 
I said already, this is an internal and minor detail of the package that 
the user will never get in touch with anyway. The implementations would 
be more or less equivalent. So why spending precious time modifying 
internal code that works already? I think we've already wasted too much 
time discussing this detail anyway, so as it obviously has a much higher 
importance to you I'd simply suggest you go ahead with the modification. 
As long as the package works as before I don't mind how the internals 
are implemented.

- Matthias -