Re: [pygccxml-development] FT -subst_t

[Roman Y. <rom...@gm...>]

On 10/10/06, Matthias Baas <ba...@ir...> wrote:
> Roman Yakovenko wrote:
> > On 10/8/06, Matthias Baas <ba...@ir... <mailto:ba...@ir...>> wrote:
> >  > Roman Yakovenko wrote:
> >  > > I don't understand why derived class code_manager_t should have
> > ugly variable
> >  > > names: ARG_LIST_DEF,  ARG_LIST_TYPES and etc. This is not coding
> > convention
> >  > > of Py++.
> >  >
> >  > I was using upper case variables for sort of "low level" variables that
> >  > are usually initialized by corresponding lower case variables.
> >  > From the
> >  > point of view of the function transformer class these variables can be
> >  > regarded as internal variables that the transformers usually don't get
> >  > in touch with.
> >  > But from the point of view of the code creator these are the variables
> >  > that it has to use for substitution.
> >
> > I don't understand "low level" variables. If I understand the code right
> > you have these variables and few methods that modifies them, right?
> > So what is "low level" in this? This pattern is widely used in Py++.
>
> Well, with "low level" I just meant that they are 1) always of type
> string and used directly for substitution and 2) that the function
> transformers will usually not manipulate those variables directly.

I will post about this in different thread.

> I just went over it again and actually you're only making comments
> instead of posing questions. So, erm, there's actually nothing to
> answer... ;) Please rephrase any questions that are important for you to
> move the functionality forward.

Fair enough.

I propose to delete subst_t class. Main reason:
Method substitute defines some logic, according to which this it decides how to
indent the code. This is just wrong. code_manager_t class understands
the meaning of
the variables, so it is its respocibility to indent the code. Without
subsitute method this
class is pretty useless.

Do you agree with me?

-- 
Roman Yakovenko
C++ Python language binding
http://www.language-binding.net/