Re: [pygccxml-development] [FT] recent changes

[Matthias B. <ba...@ir...>]

Roman Yakovenko wrote:
> 1. rename gil_state_t to gil_controller_t

Done (I renamed it to gil_guard_t as was suggested and approved in 
another mail).

> 2. to put gil_controller_t under pyplusplus::threading namespace
>     pyplusplus is top level namespace, like boost. Every functionality should
>     belong to it's own namespace.

Done.

> 3. creator_t:
>     self.__extmodule.adopt_creator( code_creators.include_t(
> code_repository.gil_state.file_name )
>                                                          ,
> self.__extmodule.first_include_index() + 1)
>     Is there is a reason why do you want to put your file to be the second one?
>     If not, I think you can swith to module_t.adopt_include method

I was just copying this line from another place in Py++, I don't need it 
it at the second position. I noticed that there is even an add_include() 
method which is what I'm using now.

- Matthias -