Re: [pygccxml-development] [FT] recent changes
Brought to you by:
mbaas,
roman_yakovenko
From: Matthias B. <ba...@ir...> - 2006-09-21 09:58:34
|
Allen Bierbaum wrote: > Roman Yakovenko wrote: > >> Hi. Few comments on committed code: >> >> 1. rename gil_state_t to gil_controller_t >> In my opinion it is better describes what we are doing >> >> > Technically the pattern it implements is a guard, so I would suggest > gil_guard_t if it was to be renamed. I was calling it gil_state_t because it wraps the PyGILState_STATE type but gil_guard_t is fine with me as well. I've just committed the modification. - Matthias - |