Re: [pygccxml-development] [FT] recent changes

[Allen B. <al...@vr...>]

Roman Yakovenko wrote:

>Hi. Few comments on committed code:
>
>1. rename gil_state_t to gil_controller_t
>    In my opinion it is better describes what we are doing
>  
>
Technically the pattern it implements is a guard, so I would suggest 
gil_guard_t if it was to be renamed.

-Allen

>2. to put gil_controller_t under pyplusplus::threading namespace
>    pyplusplus is top level namespace, like boost. Every functionality should
>    belong to it's own namespace.
>
>3. creator_t:
>    self.__extmodule.adopt_creator( code_creators.include_t(
>code_repository.gil_state.file_name )
>                                                         ,
>self.__extmodule.first_include_index() + 1)
>    Is there is a reason why do you want to put your file to be the second one?
>    If not, I think you can swith to module_t.adopt_include method
>
>
>  
>