[pygccxml-development] [FT] recent changes
Brought to you by:
mbaas,
roman_yakovenko
|
From: Roman Y. <rom...@gm...> - 2006-09-20 18:06:53
|
Hi. Few comments on committed code:
1. rename gil_state_t to gil_controller_t
In my opinion it is better describes what we are doing
2. to put gil_controller_t under pyplusplus::threading namespace
pyplusplus is top level namespace, like boost. Every functionality should
belong to it's own namespace.
3. creator_t:
self.__extmodule.adopt_creator( code_creators.include_t(
code_repository.gil_state.file_name )
,
self.__extmodule.first_include_index() + 1)
Is there is a reason why do you want to put your file to be the second one?
If not, I think you can swith to module_t.adopt_include method
--
Roman Yakovenko
C++ Python language binding
http://www.language-binding.net/
|