Re: [pygccxml-development] Comments on module_builder cache functionality

[Allen B. <al...@vr...>]

Roman Yakovenko wrote:

>Hi. I review the functionality you added to module builder, also I
>like the idea,
>I don't agree with implementation.
>
>1. You can not use "print" statements within the code. Please change them to
>    self.logger.debug, except loading and save messages. In my opinion
>    they should be info.
>  
>
Agreed.  those should not be there.  I will fix it.

>2. pygccxml class defines cache classes, why you can not reuse one of them?
>  
>
I use the signature methods from there, but the cache classes from there 
are based on the concept of mapping from a key to a cached value.  In 
this case we just want to load/dump the state of a single object that we 
know ahead of time and we only want to load it if we know the key 
matches.  This is a different set of requirements so I just did it locally.

>3. Why do you think it could be useful to have cache and module_cache
>    arguments? In my opinion, if you want to provide simple interface
>leave only one
>    of them - cache and make it work with pygccxml.
>
>  
>
I did it this way so I didn't break the old API in any way.  I have no 
problem with changing it though if you support the change.

-Allen