[pygccxml-development] Comments on module_builder cache functionality
Brought to you by:
mbaas,
roman_yakovenko
|
From: Roman Y. <rom...@gm...> - 2006-08-28 20:03:04
|
Hi. I review the functionality you added to module builder, also I
like the idea,
I don't agree with implementation.
1. You can not use "print" statements within the code. Please change them to
self.logger.debug, except loading and save messages. In my opinion
they should be info.
2. pygccxml class defines cache classes, why you can not reuse one of them?
3. Why do you think it could be useful to have cache and module_cache
arguments? In my opinion, if you want to provide simple interface
leave only one
of them - cache and make it work with pygccxml.
--
Roman Yakovenko
C++ Python language binding
http://www.language-binding.net/
|