Re: [pygccxml-development] Another performance tweak

[Allen B. <al...@vr...>]

Roman Yakovenko wrote:

> On 8/26/06, Allen Bierbaum <al...@vr...> wrote:
>
>> Sorry about this one then.  I can back out the revision if you like.
>
>
> No, no, no! You are doing grate job. I just want to create good unit 
> tests
> for every case. It can be very difficult to find a bug if there is a
> cache functionality
> somewhere.
>
Do you think there are cases that are not already covered by the current 
unit tests?

>> See my previous e-mail, I don't know how to finish up the previous
>> change because I don't understand the issue involved.  I made sure the
>> code passed the test suites, but that is about all I can do.  I think
>> you are going to have to look at it or come up with a test case that
>> shows the problem to me.
>
>
> I did not plan to work on this, but I think I will have some free time
> this evening,
> so I will work on both changes you introduced.
>
>> I will just keep any further performance increases in my own tree for 
>> now.
>
>
> Yes please. The better idea is to post them to the list.  It will take
> me day or two
> to complete the task.
>
>> If you are interested in looking into some of this I would point you at
>> check_name.  This method is now one of the most time consuming.  I can't
>> really understand what the implementation is doing but there may be room
>> for improvement.
>
>
> Yes of course. Let me finish with previous 2 and we will fix most( all
> ) of them.
>
>> It is also worth noting that when I turn on optimize_queries, the code
>> runs slower.
>
>
> What do you mean? module_builder_t.__init__ optimize_queries is turned on
> by default. May be I am missing something?

I mean that a month or so ago I found that if I turned them off, my 
script would run faster.  This is still true with the new optimizations.

-Allen

>
>