Re: [pygccxml-development] Performance problems and fixes

[Allen B. <al...@vr...>]

Roman Yakovenko wrote:

> On 8/25/06, Allen Bierbaum <al...@vr...> wrote:
>
>> (all of these are in pygccxml)
>> - Getting names from declarations
>
>
> Please remove comments you added to the declaration_t class. We don't 
> really
> need them.

I was hoping to get some feedback on that commented out code in 
declaration.py.

See the diff:  
http://svn.sourceforge.net/viewvc/pygccxml/pygccxml_dev/pygccxml/declarations/declaration.py?r1=466&r2=465&pathrev=466

Can you explain what makes the commented out code fail, and is there 
anything that can be done to fix it up?

Also, why is there a _get_name_impl method at all.  Why isn't it just 
named _get_name?  It looked to me last night like a polymorphic 
_get_name method should work fine.

-Allen