Re: [pygccxml-development] pypp_api review

[Roman Y. <rom...@gm...>]

On 3/6/06, Allen Bierbaum <al...@vr...> wrote:
> The current interface is not polished yet and doesn't even work.  I
> really need answers to the questions posed in the message titled
> "Updated status" from 03/04/2006 07:03 PM on this list.  Please take a
> look at that message so we can start discussing it.

I'd like, but it seems that I do not have such message. Can you post it aga=
in?

> Roman Yakovenko wrote:
>
> >2. I could be wrong, but pyplusplus has now all functionality provided b=
y
> >    DeclWrapper and MultiDeclWrapper. May be they should be removed?
> >
> >
> It was never really my intention to remove these since the idea is that
> DeclWrapper will add an easy to use user-level API for interfacing with
> the decls. (ie. users are not required to use the internal APIs or
> understand anything about pyplusplus)  There are still several things in
> the interface that I can't do with the pyplusplus wrappers (if I could
> get access to them).  (see message above)

I don't have that message, I could tell more when I read it.

> >3. iterdecls - this functionality already exists. Please see
> >    pygccxml/declarations/algorithm.py function __make_flatten_generator=
.
> >    It has all functionality provided by iterdecls. Also I did not use
> >it because of
> >    performance, it is slowly then creating a list and then iterating ov=
er it.
> >    But I could be wrong.
> >
> >
> I will check into this.  If they are the same I would say I like the
> name iterdecls better at least because it sounds more like something
> that would iterate over a tree of decls.  __make_flatten_generator
> sounds more like something that creates a new list.

I wrote it and tested. I did not like performance, so I rename it to be pri=
vate.
You can rename it to iterdecls.

> >4. I created 2 new printers: decl_printer_t in pygccxml/declarations pac=
kage
> >    and decl_wrapper_printer_t in pyplusplus/decl_wrappers, that derives=
 from
> >    decl_printer_t. As a bonus, decl_wrapper_printer_t prints all
> >relevant properties from
> >    declaration wrappper classes.
> >
> >
> Does one of these have the modifications that I had in the helper
> printer in the pyppapi?  I had modified that printer to print less a
> less verbose tree in a way that I think would be of help to users trying
> to wrap an API.

If not than this is a bug. I left all functionality you created.


> I need to look into this once I can get the code working again.  We also
> need to make a list of all the things that we would want to be able to
> configure and set.  This would help us to understand how it may be best
> presented to a user.

Yes this is what I will try to do this evening.

> When you refer to module_builder are you talking about some new class
> you have added in pyplusplus?

No. I am just switched to pyplusplus coding convention. I refer to the
class that you and
Matthias will create. I am waiting for this. I took a look on the
ModuleBuilder class\module
and moved some functionality to the right place. That's all.


> -Allen


--
Roman Yakovenko
C++ Python language binding
http://www.language-binding.net/