Re: [pygccxml-development] Two patches proposal

[Roman Y. <rom...@gm...>]

On Thu, Dec 24, 2009 at 11:47 AM, Berserker <ber...@ho...> wrote:
>> English is not mother language too. May be I choose the wrong and too
>> much strong word.
>
> NP, back "in topic" I think that there is a problem with your implementation
> :)
>
> consider this case:
>
> class Foo
> {
> public:
>    Foo(int a = 0, bool v = true);
> };
>
> Using your code:
>
> if 1 != len( self.required_args ):
>    return False
>
> It doesn't produces a "convertible from int" becase the required_args are 0
> but here
> we have a "convertible from int" class too.
>
> Tested again with mine it works:
>
> args = len(self.arguments)
> if args != 1:
>    if args > 1:
>       for arg in self.arguments[1::]:
>          if not arg.default_value:
>             return False
>    else:
>       return False
>
> Let me know

You are right. I will fix it this evening.


-- 
Roman Yakovenko
C++ Python language binding
http://www.language-binding.net/