#24 FTBFS: ./python/fltk_wrap.cpp:5241:35: error: format not a string literal and no format arguments [-Werror=format-security]

[Nirgal Vourgère]

From https://bugs.debian.org/759824

You source doesn't compile if you filter security unsafe formating, like disabling printf(txt) if you are not sure txt doesn't have a '%' in it.

x86_64-linux-gnu-gcc -pthread -g -O0 -Wall -Wstrict-prototypes -fno-strict-aliasing -g -O0 -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DUNIX=1 -I/usr/include/libpng12 -I/usr/include/libdrm -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/include/cairo -I./src -I./contrib -I/usr/include -I/usr/include/python2.7_d -c ./python/fltk_wrap.cpp -o build/temp.linux-x86_64-2.7-pydebug/./python/fltk_wrap.o -DDO_NOT_USE_THREADS
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
./python/fltk_wrap.cpp: In function 'const char fl_vararg_input(const char, const char)':
./python/fltk_wrap.cpp:5241:35: error: format not a string literal and no format arguments [-Werror=format-security]
result = fl_input(label, deflt);
^
./python/fltk_wrap.cpp: In function 'const char fl_vararg_password(const char, const char)':
./python/fltk_wrap.cpp:5247:38: error: format not a string literal and no format arguments [-Werror=format-security]
result = fl_password(label, deflt);
^
./python/fltk_wrap.cpp: In function 'void fl_mt_message(const char)':
./python/fltk_wrap.cpp:5285:20: error: format not a string literal and no format arguments [-Werror=format-security]
fl_message(text);
^
./python/fltk_wrap.cpp: In function 'void fl_mt_alert(const char)':
./python/fltk_wrap.cpp:5291:18: error: format not a string literal and no format arguments [-Werror=format-security]
fl_alert(text);
^
./python/fltk_wrap.cpp: In function 'int fl_mt_ask(const char)':
./python/fltk_wrap.cpp:5298:14: warning: 'int fl_ask(const char, ...)' is deprecated (declared at /usr/include/FL/fl_ask.H:47) [-Wdeprecated-declarations]
status = fl_ask(text);
^
./python/fltk_wrap.cpp:5298:25: error: format not a string literal and no format arguments [-Werror=format-security]
status = fl_ask(text);
^

[Andreas Held]

Fixed in release V1.3.3