Re: [Pydev-code] PyDev Build doesn't explode bundles
Brought to you by:
fabioz
Menu
▾
▴
Re: [Pydev-code] PyDev Build doesn't explode bundles
|
From: Fabio Z. <fa...@gm...> - 2016-03-01 10:34:25
|
Hello Mark, Sorry for closing the issue... I just commented there, but I'll explain it again here ;) Mainly, I changed the PyDev structure to do the development in the 'master' branch and not in the 'development' branch, the main reason being that the master branch was being used mostly as a tag, which I think was kind of odd -- as a reference, it's the way that http://nvie.com/posts/a-successful-git-branching-model/ recommended, but I currently find that to be a bad decision as the master branch ended up being pretty much useless and sometimes things got confusing during the release -- anyways, when I deleted the development branch, github automatically closed all pull requests which were targeting it (unfortunately, I didn't foresee that and github doesn't allow me to change that pull request to target the new branch -- so, please, just recreate your pull request targeting the master branch). Best Regards, Fabio On Mon, Feb 29, 2016 at 8:33 PM, Mark Leone <mid...@ve...> wrote: > Thanks, Jonah. You're correct about the build expanding. The maven-built > product has exploded bundles and seems to work fine. The problem I'm having > is when I launch my product as a run-time workbench from eclipse during > development. I add the local p2 repo created by the PyDev build to my > target, and since the bundles aren't exploded I get the errors. I can > create a Directory type target location with the PyDev source code in it. > But my product is an IDE , and we make all our source code available. So > I'll be including the PyDev code in two different locations, one for use > with maven and the other for development-time target use. It would be nice > to generate a p2 repo with exploded bundles, but maybe there isn't a way to > do that. With the PDE export tooling, you can't specify exploded bundles if > you want a p2 repo. > > Of course if/when my mods are incorporated into PyDev it won't be an > issue. As for what they are, it's the Pull Request I created for the hover > participant mods that we discussed. I sent an e-mail to the list a couple > weeks ago with the link, but here it is again: > https://github.com/fabioz/Pydev/pull/159 > > Fabio had some comments on Github which I addressed, although I was > waiting for confirmation on one problem that I couldn't reproduce. Last > week the PR got closed with no comment and without being merged. I wondered > if it was an automatic thing, because I created the PR to merge on > development, and maybe I should have specified master. On Github last week > all the branches except master and old_development disappeared, although I > can still see the other ones with my git client. I'm not sure what's going > on there. I sent an e-mail direct to Fabio about it, and haven't heard back > yet. I'm sure he's busy, and anyway I didn't expect to get these changes > into PyDev in time for today's release anyway, so I was always planning on > doing my own packaging for this one. > > It would be great if you want to take a look at the PR. Let me know if you > have any questions or comments. > > -Mark > > > On 02/29/2016 05:20 PM, Jonah Graham wrote: > > Number 3 was supposed to read > > 3) The feature xml often has "unpack" attribute omitted which then comes > to the default of *true*. > > > On Monday, 29 February 2016, Jonah Graham < <jo...@ki...> > jo...@ki...> wrote: > >> Hi Mark, >> >> I don't have access to try before I send this to you. But a few pointers >> that may or may not help (including some duplication of what you have >> already figured out): >> >> 1) The jar in the P2 site should be a jar, the p2 install process should >> explode it. You may be missing the "install" step depending on how you have >> your target platform set up. >> 2) Check shape of the bundle is dir (in manifest, the Eclipse-BundleShape >> directive) >> http://help.eclipse.org/mars/topic/org.eclipse.platform.doc.isv/reference/misc/bundle_manifest.html?cp=2_1_5_10 >> 3) The feature xml often has "unpack" attribute omitted which then comes >> to the default of false. >> 4) The Jython addon for Eclipse EASE also includes jython.jar exploded, >> so it may be a useful checkpoint (I am not recommending using that version, >> but comparing against it may be useful). >> Source: https://github.com/eclipse-ease-addons/jython >> p2 site: https://dl.bintray.com/pontesegger/ease-jython/ >> >> PS I am very curious what you are building with all these great changes, >> I hope you can let us curious people know when it is ready. >> >> Jonah >> >> >> >> ~~~ >> Jonah Graham >> Kichwa Coders Ltd. >> www.kichwacoders.com >> >> On 29 February 2016 at 21:52, Mark Leone <mid...@ve...> >> wrote: >> >>> I'm doing a PyDev build so I can incorporate a modified version of PyDev >>> in my app which I'm releasing today. I add the generated p2 repo to my >>> target platform, but when I launch the runtime workbench I get lots of >>> errors because apparently the org.python.pydev.jython bundle needs to be >>> exploded rather than in jar form. (the error message is "Can't find >>> relative path:. within:org.python.pydev.jython_4.5.2.201602292131 [710]") >>> >>> The maven pom file seems to be configured to explode all bundles. I also >>> tried adding unpack="true" for org.python.pydev.jython in feature.xml. >>> Still the p2 site is created with jar files. Does anyone know how I can >>> create a p2 site with exploded bundles, or at least the jython bundle >>> exploded? >>> >>> -Mark >>> >>> >>> ------------------------------------------------------------------------------ >>> Site24x7 APM Insight: Get Deep Visibility into Application Performance >>> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month >>> Monitor end-to-end web transactions and take corrective actions now >>> Troubleshoot faster and improve end-user experience. Signup Now! >>> http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 >>> _______________________________________________ >>> pydev-code mailing list >>> pyd...@li... >>> https://lists.sourceforge.net/lists/listinfo/pydev-code >>> >> >> > > -- > ~~~ > Jonah Graham > Kichwa Coders Ltd. > www.kichwacoders.com > > > > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now!http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 > > > > _______________________________________________ > pydev-code mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/pydev-code > > > > > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 > _______________________________________________ > pydev-code mailing list > pyd...@li... > https://lists.sourceforge.net/lists/listinfo/pydev-code > > |
