Re: [Pydev-code] New Auto Config issues

[Jonah G. <jo...@ki...>]

OK, I have implemented the runInstall as intended, i.e. it now runs
only if the user selected it or if there is only one provider.

Unfortunately this has made a complicated function even more
complicated, so any review on it is probably a good idea. See
https://github.com/fabioz/Pydev/pull/93

Jonah
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com



On 28 October 2013 15:31, Jonah Graham <jo...@ki...> wrote:
> Hi,
>
> I have fixed (potentially) Bug 229:
> https://github.com/jonahkichwacoders/Pydev/tree/exclude_operation_that_have_failed
>
> The bug got in the way of me trying to code up what I said below.
>
> Jonah
>
>
> ~~~
> Jonah Graham
> Kichwa Coders Ltd.
> www.kichwacoders.com
>
>
>
> On 28 October 2013 15:24, Jonah Graham <jo...@ki...> wrote:
>> Hi Andrew,
>>
>> A further problem has been identified with your changes. Summarized by
>> this TODO that you added in AutoConfigMaker:autoConfigSearch():
>>                     if (!provider.isInstalled()) { //TODO should it
>> ALWAYS be installed here??
>> The answer is that it isn't always installed here, for example we (at
>> Diamond/DAWN) use this to optionally install a Python install. I.e.
>> what should be presented is an uninstalled version in the list and if
>> the user selects it then in should then be installed before the
>> configuration is continued.
>>
>> I am working on a proposed fix for this as perhaps the fix may explain
>> better why the API has an "isInstalled" and a "runInstall" method.
>>
>> Thanks,
>> Jonah
>> ~~~
>> Jonah Graham
>> Kichwa Coders Ltd.
>> www.kichwacoders.com
>>
>> On 28 October 2013 13:47, Andrew Ferrazzutti <afe...@re...> wrote:
>>> Hi Jonah,
>>>
>>> Thanks for the heads up. These problems are happening because I changed the auto-configurers to find interpreters whose names begin with a target string ("python"/"jython" etc) as opposed to exactly matching the string like they used to.
>>>
>>> I did made this change to allow the auto-configurers to find more than just the most recent version of an interpreter (ie "python2.7" and "python3.3", not just "python"). Clearly there are some issues with my implementation that I overlooked, and I'll get to fixing them right away.
>>>
>>> Andrew
>>>
>>> ----- Original Message -----
>>> From: "Jonah Graham" <jo...@ki...>
>>> To: pyd...@li...
>>> Sent: Friday, October 25, 2013 5:59:52 AM
>>> Subject: [Pydev-code] New Auto Config issues
>>>
>>> Hi Andrew,
>>>
>>> I was just testing the new auto-config changes you contributed on
>>> Ubuntu 12.04 and I ran into a couple of issues. I filed them in the
>>> tracker, but wanted to alert you to them in case you didn't see them
>>> already.
>>>
>>> https://sw-brainwy.rhcloud.com/tracker/PyDev/228
>>> https://sw-brainwy.rhcloud.com/tracker/PyDev/229
>>>
>>> Thanks
>>> Jonah
>>>
>>> ~~~
>>> Jonah Graham
>>> Kichwa Coders Ltd.
>>> www.kichwacoders.com