Hi all,
i have created a new colorset and also modified the CScreen.py
When i download the newest Source, i have to change my modifications again.
Is there a way to get around this?
Thx
Chrigu
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
thx
i will send you other changes, feel free to merge them if its ok for you.
i have added a game to learn score and in ho_one i write all the darts in an sql server database
monochrome and statistc type :-)
probably this is not to include in source but its no problem for me
thanks for write this software, it's great
cheers
chrigu
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi Chrigu,
Feel free to submit other changes if you like ! That's great to have help developping pyDarts. I have always developped it alone :)
But, to keep the spirit of the game, just don't forget to :
always think "wide". I mean the functionnality must be usable for the widest range of users, without having something too specific. Or do not code somthing only for one game, always port your changes to all games in a row, even if you don't use them.
think "long term" when you code. Think that your code should always be as maintainable as possible. Comment your changes, obviously, etc
think "open source". Do not commit closed source code or a piece of code that use external closed source software.
That a kind of "policy" that could seems obvious ;) Thanks in advance.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
hi poilou,
is there a way to refresh my fork on sourceforge with your newest changes
i have tried refresh repository but your changes from yesterday are not included
cheers
chrigu
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
hi poilou
while i trying to sync the fork, here are my changes, feel free if you will include it in your project
there are also 2 pictures
the changes will switch the backgroundimage when greyscale is chossed and it will also change the target picture to smaller ones if the showoptionsparameter is choosen
cheers chrigu
Hi poilou
i have download the latest source but it did not work
i have commented the Line
from include.config import * because the config is not existing
cheers
chrigu
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
You where right there were a bug in pydarts.py with the "import config".
It was not supposed to be there anymore.
But because I had a compiled version of the file (config.pyc) in moy
folder, it still worked for me.
A shame ! a newbie error ;)
Bye
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi all,
i have created a new colorset and also modified the CScreen.py
When i download the newest Source, i have to change my modifications again.
Is there a way to get around this?
Thx
Chrigu
Hi Chrigu,
The best way would be to integrate your changes to the main code.
First : the most "clean" way (but require a bit of dev skills):
Second and "easy way" (it look easy but it is not really). Good for "small" changes only:
Cheers :)
Last edit: poilou 2017-04-17
Hi poilou
i will read this article and try to send a request this week
tanks
chrigu
Hi poilou
i have sent a request, hope it was the right way :-)
cheers
chrigu
Hi Chrigu !
I am not familiar with merging, but it's a good way to learn :)
I've merged your changes, since they produce no conflict.
Nice idea to create a grayscale colorset. In my opinion the background grey is a little bit too dark and it sometimes lacks a bit of contrast.
What do you think ?
Hi poilou
im the monochrom type i have also added a black backgound with 1920 * 1080 pixel
with this background it works fine for me
In CScreen.py i have also added
#Display if self.ChoosenColorSet != "grayscale": self.BlitRect(X,Y,SX,SY,self.ColorSet['black'])3 times
so the background is not colored in the rounds on gamepicture and by the darts
Last edit: Chrigu Wuethrich 2017-04-17
Ok great, no problem so !
thx
i will send you other changes, feel free to merge them if its ok for you.
i have added a game to learn score and in ho_one i write all the darts in an sql server database
monochrome and statistc type :-)
probably this is not to include in source but its no problem for me
thanks for write this software, it's great
cheers
chrigu
Hi Chrigu,
Feel free to submit other changes if you like ! That's great to have help developping pyDarts. I have always developped it alone :)
But, to keep the spirit of the game, just don't forget to :
That a kind of "policy" that could seems obvious ;) Thanks in advance.
hi poilou,
is there a way to refresh my fork on sourceforge with your newest changes
i have tried refresh repository but your changes from yesterday are not included
cheers
chrigu
Hi Chrigu,
I've never done this but have a look to this doc :
https://help.github.com/articles/syncing-a-fork/
Good luck git is such a powerful mess ;)
hi poilou
while i trying to sync the fork, here are my changes, feel free if you will include it in your project
there are also 2 pictures
the changes will switch the backgroundimage when greyscale is chossed and it will also change the target picture to smaller ones if the showoptionsparameter is choosen
cheers chrigu
Hi poilou
i have download the latest source but it did not work
i have commented the Line
from include.config import * because the config is not existing
cheers
chrigu
Hey Chirgu,
Your code is not up-to-date...
I've removed this line since 3 days at least...
Hi Chrigu !
You where right there were a bug in pydarts.py with the "import config".
It was not supposed to be there anymore.
But because I had a compiled version of the file (config.pyc) in moy
folder, it still worked for me.
A shame ! a newbie error ;)
Bye
hi poilou
no problem, i make mistakes each week :-)
cheers
chrigu