This patch fixes bug #524393 by 1) getting
the 'module' attribute of a new Class instance
right, and 2) skipping _findClassWarnings() on
classes defined in a module other than the one
currently being checked.
I applied the patch to checker.py and there is no problems
with the regression tests. However, when applying the patch
to warn.py (if c.module is module:), many tests fail.
I tested with 2.1.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
OOOPS! This patch has been broken all along.
"c.module is module" should have been "c.module is
module.module" -- DOHH!
That might explain why some PyChecker tests
failed. It certainly explains some problems I
have been having. Uploading yet another version
of the patch.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I think I'm going to use this patch, but as a cmd line option.
So if the user uses the option it means
"only return warnings from files I pass on the command line."
Otherwise, check all files (as it does today).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Logged In: YES
user_id=14422
Oops. That patch fell down and went boom as soon
as it got close to a real-life ExtensionClass. Sigh.
New version attached.
Logged In: YES
user_id=33168
I think the bug is now fixed (in a different way).
But there seems to be some good elements of this patch.
Logged In: YES
user_id=14422
No, as near as I can tell bug #524393 is still alive
in the current CVS code. This patch, or something like
it, is needed to kill that bug.
Logged In: YES
user_id=33168
I applied the patch to checker.py and there is no problems
with the regression tests. However, when applying the patch
to warn.py (if c.module is module:), many tests fail.
I tested with 2.1.
Logged In: YES
user_id=14422
I'm uploading a revised version of this patch that
only includes the part Neal hasn't already accepted.
Logged In: YES
user_id=14422
I'm uploading a revised version of this patch that
only includes the part Neal hasn't already
accepted.
Logged In: YES
user_id=33168
When I run this patch on 2.2 I get lots of errors.
Is there anything else other than
if c.module is module:
added?
test28 is a short one that fails for me with 2.2,
but I think everything works with 2.1.
Logged In: YES
user_id=14422
OOOPS! This patch has been broken all along.
"c.module is module" should have been "c.module is
module.module" -- DOHH!
That might explain why some PyChecker tests
failed. It certainly explains some problems I
have been having. Uploading yet another version
of the patch.
Logged In: YES
user_id=33168
I think I'm going to use this patch, but as a cmd line option.
So if the user uses the option it means
"only return warnings from files I pass on the command line."
Otherwise, check all files (as it does today).