From: Thomas V. S. <th...@ap...> - 2009-09-30 14:37:52
|
Continuing on my cleanup path... > 2.6: 16 failures > 2.5: 12 failures > 2.4: 6 failures > 2.3: 8 failures What I'm focussing on so far is to bring all python versions on par with the one with the lowest failures, 2.4 I've first brought back 2.6 to the same failures as 2.5; basically, all new failures were due to the way BUILD_MAP has changed and can now take a numeric argument to presize the dict. This argument however is not the number of items to consume from the stack. Fixing that bug in pychecker made failures for 2.6 the same as for 2.5 As for between 2.5 and 2.4, I'm going over each of them and figuring out what happened. A few have been fixed simply because Python 2.5 introduced code generator optimizations that optimize the problematic code away before pychecker has a change to get at it; examples: 55555 % 1 gets replaced with the constant 1 ~~(10) (double negation) gets replaced with 10 Since pychecker has no way of knowing what the code was like before it got constified, there's no way to warn about it afaict. (Please correct me if I'm wrong here). So in those cases, I created a new expected results file, removing the warnings. At least one of the differences I will need more help on, but for now the score is: 2.6/2.5: 9 2.4: 6 2.3: 8 I have to say I feel a lot more comfortable changing tricky python code with these buildbots around to check all python versions for me... Thomas -- P.S. You rock my world -- savon - Saving your work to svn https://apestaart.org/thomas/trac/ |