#10 unify code in DropCutter

closed-accepted
nobody
None
5
2010-03-09
2010-01-30
Lars
No

Hi,
the DropCutter code contained two similar branches for x/y directions.
The attached patch unifies both code parts.

Additionally this seems to have fixed some glitch in the previous code, as you can see by comparing the "old_?.png" and "new_?.png" pictures in the attachment. These are screenshots taken for the x and y directions with the previous and the patched version of the DropCutter code. All settings are identical.

greetings,
Lars

Discussion

  • Lars

    Lars - 2010-01-30

    original code in x direction

     
  • Lars

    Lars - 2010-01-30

    original code in y direction

     
  • Lars

    Lars - 2010-01-30

    result of new code in x direction

     
  • Lars

    Lars - 2010-01-30

    result of new code in y direction

     
  • Lode Leroy

    Lode Leroy - 2010-02-01

    could you split this in two parts? one part being the fix for the problem, and one part for the unification?

     
  • Lars

    Lars - 2010-02-01

    check both limits of new point

     
  • Lars

    Lars - 2010-02-01

    the attached patch "glitch_fix.patch" fixes the problem for my model.

     
  • Lars

    Lars - 2010-02-10

    Hopefully this patch fixes the root cause of the glitch.

     
  • Nobody/Anonymous

    the above patch was integrated

     
  • Lars

    Lars - 2010-03-09
    • status: open --> closed-accepted
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks