Re: [Pyblosxom-devel] Fix time zone dependent tests

[will kahn-g. <wi...@bl...>]

I'm really sorry that it took so long.

I just added your repository as a remote and looked at the commits.  I
have these thoughts:

8edfe5b:

The __force_tz and __restore_tz should be put in a decorator.  So if the
test fails at set_time, we're not put in a weird situation where
__force_tz has changed the environment, but __restore_tz never gets run.

So then tests that need tz forced would be decorated.


c09e5e83:

This one puzzles me.  The added comment is good.  However, the other
change is moving the w3cdate.  w3cdate is built off of the gmtuple which
is based in GMT.  Are you positive there's a problem here?  Can you
write a unit test that shows the problem?


Again, I really apologize for taking so long.  Thank you for pinging me
again.

/will


On 04/07/2011 06:34 PM, Mikko Varri wrote:
> 
> On Fri, Mar 18, 2011 at 10:43:50PM -0400, will kahn-greene wrote:
>> On 03/18/2011 08:33 PM, Mikko Varri wrote:
>>> On Thu, Mar 17, 2011 at 09:40:30PM -0400, will kahn-greene wrote:
>>>>
>>>> Things I still need help with:
>>>>
>>>> 2. Running the unit tests.
>>>>
>>>
>>> I ran the unit tests on Slackware64 13.37rc2 and noticed that two
>>> tests were failing.  Both turned out to be time zone dependent, so I
>>> fixed the tests instead of the code under test.  You can see the
>>> change in my pyblosxom clone[1], change 8edfe5b[2].
>>>
>>> There's a couple of other changes, too, but they are not fixing any
>>> functionality.  Change 37c5602[3] is about a bit of documentation, and
>>> c09e5e8[4] moves the 'w3cdate' definition out of the setlocale scope.
>>>
>>> [1] http://gitorious.org/~vmj/pyblosxom/vmjs-pyblosxom/commits/master
>>>
>>> [2] http://gitorious.org/~vmj/pyblosxom/vmjs-pyblosxom/commit/8edfe5bba57796db24f54baea4bc3d3194400789
>>>
>>> [3] http://gitorious.org/~vmj/pyblosxom/vmjs-pyblosxom/commit/37c5602747d8e37e5713e4bad41a1494c2aeceb9
>>>
>>> [4] http://gitorious.org/~vmj/pyblosxom/vmjs-pyblosxom/commit/c09e5e83688a679aea687f73e702e49132a1debb
>>>
>>
>>
>> I'll take a look at these in the next day or two.
>>
> 
> Did you have a chance to take a look at these?
> 
> I merged your latest changes into my clone, so it should be easier to
> digest.
> 
> -vmj
> 
> ------------------------------------------------------------------------------
> Xperia(TM) PLAY
> It's a major breakthrough. An authentic gaming
> smartphone on the nation's most reliable network.
> And it wants your games.
> http://p.sf.net/sfu/verizon-sfdev
> _______________________________________________
> Pyblosxom-devel mailing list
> Pyb...@li...
> https://lists.sourceforge.net/lists/listinfo/pyblosxom-devel
>