Re: [Pyblosxom-devel] Fix time zone dependent tests

[Mikko V. <vm...@li...>]

On Fri, Mar 18, 2011 at 10:43:50PM -0400, will kahn-greene wrote:
> On 03/18/2011 08:33 PM, Mikko Varri wrote:
> > On Thu, Mar 17, 2011 at 09:40:30PM -0400, will kahn-greene wrote:
> > >
> > > Things I still need help with:
> > >
> > > 2. Running the unit tests.
> > >
> > 
> > I ran the unit tests on Slackware64 13.37rc2 and noticed that two
> > tests were failing.  Both turned out to be time zone dependent, so I
> > fixed the tests instead of the code under test.  You can see the
> > change in my pyblosxom clone[1], change 8edfe5b[2].
> > 
> > There's a couple of other changes, too, but they are not fixing any
> > functionality.  Change 37c5602[3] is about a bit of documentation, and
> > c09e5e8[4] moves the 'w3cdate' definition out of the setlocale scope.
> > 
> > [1] http://gitorious.org/~vmj/pyblosxom/vmjs-pyblosxom/commits/master
> > 
> > [2] http://gitorious.org/~vmj/pyblosxom/vmjs-pyblosxom/commit/8edfe5bba57796db24f54baea4bc3d3194400789
> > 
> > [3] http://gitorious.org/~vmj/pyblosxom/vmjs-pyblosxom/commit/37c5602747d8e37e5713e4bad41a1494c2aeceb9
> > 
> > [4] http://gitorious.org/~vmj/pyblosxom/vmjs-pyblosxom/commit/c09e5e83688a679aea687f73e702e49132a1debb
> > 
> 
> 
> I'll take a look at these in the next day or two.
> 

Did you have a chance to take a look at these?

I merged your latest changes into my clone, so it should be easier to
digest.

-vmj