Re: [pyblosxom-users] Flavours and templates

[Chris G <cl...@is...>]

On Fri, Feb 05, 2010 at 10:06:36PM -0500, will kahn-greene wrote:
> On 01/30/2010 08:46 AM, Chris G wrote:
> > On Fri, Jan 29, 2010 at 12:46:28PM -0500, will kahn-greene wrote:
> >>
> >> I'm pretty sure the documentation walks through the structure of a
> >> flavour and what templates are required.  Beyond that, it's just writing
> >> the templates.
> >>
> > Yes, I hear what you're saying.  However from the *users* point of
> > view changing what a browser sees (i.e. different HTML templates) is
> > not the same sort of animal as changing the output format (i.e. HTML
> > or RSS or text or whatever).
> >
> > I think (maybe I'm wrong) that most people will be interested in
> > changing what they see in their browser, i.e. they want to output
> > 'different HTML' and the documentation doesn't really address this
> > requirement directly.
>  > [snip]
> 
> I re-read the docs and your comments and reworked the chapter.  See if 
> it's better and addresses some/most/all of your issues.
> 
> http://pyblosxom.sourceforge.net/1.5/flavours_and_templates.html
> 
Looks good in general, a couple of minor comments:-

Summary

    The bit "system-say Cheetah or htmltmpl-implement" needs some
    spaces around the dashes, I was wondering what htmltmpl-implement
    was for a while before I twigged.


Flavours and Templates
    Trivial typo "flavour files iny our datadir".  The dash just a
    little later could do with spaces.


Storing Flavours ....
    Maybe the first example could be 'joe' with the second one being
    'fred'. 


Storing Flavours in the datadir
    Brilliant, it makes everything much clearer knowing that this is
    the old and rather rubbish way of doing it.



All in all (for me at least) it's a big improvement.

-- 
Chris Green