Re: [Pybem-developers] PyAtlantis Blatherings

[Anthony B. <ab...@we...>]

On Mon, Dec 03, 2007 at 12:28:01PM +1100, Anthony Briggs wrote:
> Jan Rietema wrote:
> > 
> > But an easy start isn't going to circumvent more painful refactoring
> > and redesigning later on.
> ...
>  > What gives me the creeps is that you decided to carry over all the ugly
>  > things from A1, and schedule them for refactoring later. I think a lot
>  > of better code design could have been done from the outset - more
>  > OO-goodness, more abstraction for skills/orders/items, better
>  > configurability, and a more modular design in general. These things are
>  > painful to introduce as an afterthought.
>
> For Orders, have a quick look at the latest work that I've been doing on the order system:
> 
>    http://pybem.svn.sourceforge.net/viewvc/pybem/pyatlantis/trunk/runorders.py?view=markup
> 
>  From 'class Order:' onwards is the new version,
>  'runInstantOrders(game):' onwards is the old version. Is that what
>  you had in mind?

Just a quick note to let you guys know that I've finished that
particular refactoring (although it's just for instant orders right now,
the design is basically done for the moment).  That URL above is still good,
although there are other bits in atlantis1.py and faction.py that it
calls.

The idea behind it is mainly breaking down the massive order processing
functions that A1 is saddled with, but the long term plan is that I'll
have a directory of modules which override particular types of
functionality, add new orders, etc.

Thanks,

Anthony

-- 
------------------------------------------------------
 HyPerACtIVe?! HEY, Who ArE yoU cAllInG HYPERaCTive?!
 ab...@we...
------------------------------------------------------