[Pybeep-devel] Code cleanup

[Sean A. <ze...@wo...>]

Hi

I started looking into the existing code-base to try and clean up some
of it this weekend. Sheesh.

I think, one of the next steps forward (and quite an important one) is
to decide what we don't want in the core anymore (eg. the datastream
stuff) and cut it out soon, as its really starting to get messy in
there. I'm loosing track of which stream I'm meant to be reading from.

My suggestion is also to begin to unify the core into a single namespace
(i.e one .py file), the reasoning for this is:

1) It's more natural.
2) it avoids multiple copies of stuff loaded into various namespaces.
I'm not advocating premature optimization, but it seems pointless to
have 5 copies of the same constant sprinkled out through 5 or 6 files
3) It will be neater.=20

Basically, core.py will be a large file,but I feel it will be easier to
manage and will only include the classes we need. We can also trim those
classe quite a bit(a lot of stuff in channel/session etc seems to be
Java specific and unnecessary).

What I am proposing is this.
1) Trim and unify the core classes(Session, Channel, Message, Frame,
Scheduler etc.) into core.py, this would also mean dropping a few and
maybe moving the functionality into a single class (i.e. the
MessageStatus/Message issue)=20
2) Unify utility classes (Synchronizable, a single Queue implementation
etc.) into a util.py
3)leave the tests as is, but adapt them for new architecture (changing
imports basically)

If nobody has any objections, I would like to work on this over the next
week, as it is, IMHO really necessary, it's getting hard to navigate the
source now.

Sean=20

 =20