Re: [Pybeep-devel] updates: scheduler and stuff

[Gabe W. <gw...@wa...>]

On 1 Mar 2002, Sean Allen wrote:

> On Fri, 2002-03-01 at 04:29, Gabe Wachob wrote:
> > Checked in a bunch of edits to the core stuff tonight (er, its 4:20am -
> > thats morning I guess).
>
> Up late eh? ;-)

I "went to bed" at 6 and got up at 8:30.. A huge latte later and I'm back
at work!

> Wow.. all the tests run OK....

Only two were broken and they were trivial fixes. Maybe this means we are
behind on our test writing!!!

> > I'm thinking we need to do a major code cleanup (stylewise, naming,
> > commenting, etc) and I'd like someone who has more energy for that to be
> > the lead, if someone would be so kind.
>
> I'd be keen, I like that kind of stuff anyway.

I was hoping you'd volunteer! I'm a terribly messy coder and I really like
having someone else's structure to work against. So please have at it..
just let me know what your style guidelines are.


> > Hopefully I didn't step on anybody's plate of work here....
>
> Glad to see you're feeling better

Only marginally now that I'm working on 2 hours of sleep ;-)

> One thing I have run into in terms of using the incremental parser, is
> that the object you need to hand to it definitely needs to have a file
> interface (I have yet to dig deeper into this 'cos of time) so that is
> something to consider, if anyone is working on streams at the moment. We
> need to finalize what we are going to hand to the parser. (i.e.
> stream.getData(), or just give it the stream, or
> stream.getData().getByteStream() or whatever)

I was thinking the feed method on IncrementalParser (which just takes
string data) would obviate the need for a file-like interface. If you
look at the parse method, all it does is loop through the source parameter
calling read and passing the results to feed anyway... and even so, the
DataQueueStream has a read() method that would work just fine for parse (I
think).

	-Gabe

-- 
Gabe Wachob                   gw...@wa...
Personal                   http://www.wachob.com
CTO, WiredObjects    http://www.wiredobjects.com