Menu

#5 SetActiveLink fails without "order" parameter (e.g. rename active link)

v1.0_(example)
closed
Ergorion
1
2015-03-08
2014-08-04
Anonymous
No

I think line 3309/3310 in ars.py has a logical error:

if not isinstance(order, c_uint) or order is not None:
order = c_uint(order)

should read

if isinstance(order, c_uint) or order is not None:
order = c_uint(order)

Discussion

  • Ergorion

    Ergorion - 2014-08-05
    • status: open --> accepted
    • assigned_to: Ergorion
     
  • Ergorion

    Ergorion - 2014-08-05

    Why do you think that this is an error? Only if order is not of type c_uint, I would like to enforce it to be of that type. Therefore, it's
    if not isinstance()
    But then the "or" is wrong. It needs to be:
    if order is not None and not isinstance(order, c_uint):
    order = c_uint(order)

    I'll fix it...

     
  • Ergorion

    Ergorion - 2015-03-08

    This bug should be fixed with pyARS 1.8.2.

    • status: accepted --> closed
     

    Last edit: Ergorion 2015-03-08

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB