From: Thomas H. <th...@ct...> - 2013-11-28 11:45:24
|
I'm more concerned about the functionality of the patch, not so much about these minor issues (of course it is nicer to have a patch that applies cleanly and only changes stuff that is really required, but for me it is not a bug deal to handle that myself). About the functionality: I tried you patch (with some modifications by me) and it seems to work; I can really start an exe created by py2exe when the exe is in a directory that contains chinese characters, on my german windows installation. The problem is that it only works when the exe is started with the FULL pathname. Which apparently happens when you start it by double-clicking in explorer. This probably is caused by the fact that the Python path includes now the current directory as '.'. Of course this is not acceptable: You cannot start the exe from the command line, even if you are *inside* the exe's directory. When I have time I will experiment a little bit to find out if this restriction can be removed. Will Python work with a sys.path that contains an utf-8 encoded string? I'm not sure - it must be able to bootstrap itself even though the encodings are not available since they have to loaded from the library which is in the zip-archive that py2exe creates... Thanks for the patch anyway, it contains an interesting idea. Thomas |