From: Werner F. B. <wer...@fr...> - 2008-09-11 14:47:24
|
Matthias, Matthias Miller wrote: > Jimmy Retzlaff wrote: >> On 9/10/08 4:18 PM, "Mark Hammond" <mha...@sk...> wrote: >> >> >>>> le dahut wrote: >>>> >>>>> Hello, I've tried the new build on several applications that didn't >>>>> display the icon with Vista. >>>>> They now do it correctly. >>>>> This correction works for me ! >>>>> >>>>> Thanks >>>>> >>>>> >>>>>>> <snip> >>>>>>> >>>>>>>> On 4/25/08 11:25 AM, "Thomas Heller" <th...@ct...> wrote: >>>>>>>> >>>>>>>> >>>>>>>>> It seems that using >>>>>>>>> '1' instead of '0' at least does no harm, but it would be nice to >>>>>>>>> have someone else on Vista confirm the problem and that your new >>>>>>>>> patch fixes it: >>>>>>>>> >>>>>>>>> Thomas >>>>>>>>> >>>> Any chance of getting this patch applied now that it's been duplicated? >>>> I've attached the patch for reference. >>>> >>> IIUC, this will give the first icon in the file an ID of 1, which will break >>> a few of my apps. I wouldn't have a problem with that if it was fixing a >>> real problem - but I don't see it. I'm using a py2exe app with multiple >>> icons each with multiple images on vista without a problem. >>> >> >> I also tried to reproduce the problem on Vista (both 32 and 64-bit) with >> several different ID variations and could not get it to fail. We need to >> really understand the root cause of the problem before we try to fix it, and >> we don't really understand the root cause unless we can make it fail at will >> on different machines. >> > > > I have attached a sample that duplicates the problem on my computer. > When I build it using the py2exe out of trunk, Windows Explorer shows a > default application icon for the executable. When I build it with the > patch, Windows Explorer shows the correct icon. Just out of curiosity I copied your files to a folder and build it. Looking at the generated dist folder shows the icon you included and not a default icon (see attached jpg). I am on: Vista 32 ultimate Python 2.5.2 py2exe '0.6.6' Haven't got around to upgrade to 0.6.8 yet. Werner |