From: Stanley C. <sta...@gm...> - 2006-10-09 02:03:25
|
FYI. A patch for PXA serial driver. ---------- Forwarded message ---------- From: Todd Blumer <sdg...@gm...> Date: Oct 7, 2006 2:44 AM Subject: PXA serial change To: lin...@li... I hate to bring up this issue again, but here goes. I would really like it if we could change the internal PXA serial ports as follows (or similar, given that the devfs stuff is now removed): Index: drivers/serial/pxa.c =================================================================== RCS file: /cvs/linux/kernel26/drivers/serial/pxa.c,v retrieving revision 1.28.2.1 diff -u -r1.28.2.1 pxa.c --- drivers/serial/pxa.c 14 Jun 2006 12:21:02 -0000 1.28.2.1 +++ drivers/serial/pxa.c 6 Oct 2006 18:15:46 -0000 @@ -756,7 +756,7 @@ } static struct console serial_pxa_console = { - .name = "ttyS", + .name = "ttySA", .write = serial_pxa_console_write, .device = uart_console_device, .setup = serial_pxa_console_setup, @@ -862,10 +862,10 @@ static struct uart_driver serial_pxa_reg = { .owner = THIS_MODULE, .driver_name = "PXA serial", - .devfs_name = "tts/", - .dev_name = "ttyS", + .devfs_name = "ttsa/", + .dev_name = "ttySA", .major = TTY_MAJOR, - .minor = 64, + .minor = 64 + CONFIG_SERIAL_8250_NR_UARTS, .nr = ARRAY_SIZE(serial_pxa_ports), .cons = PXA_CONSOLE, }; For handhelds, I get tired of dealing with the fact that 8250.ko and pxa.ko don't play nicely together. This change obviously moves the namespace of pxa.c to ttySAx. The upside is that 8250 code doesn't need to be touched and serial-based CF cards like GPS and modems just work. The downside is that all of the handhelds' /etc scripts that use ttySx (console, BT, sometimes IrDA) need to change. For the iPAQ hx4700, that's just a couple of files (inittab, hciattach, and kernel boot line). Thus, I think that's pretty minor. As a side note, the i.MX serial driver uses ttySMX as the prefix and it works well. Any hope of getting this changed in the near future? Or, maybe I missed something and this problem has been resolved since 2.6.15? Thanks. -- Todd Blumer SDG Systems ------------------------------------------------------------------- List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php -- Best regards, -stanley http://pxa-linux.sf.net -- PXA Linux information centre |