Menu ▾ ▴

#582 fix crash with filename argument and endless loop

bugfix
open
Martin Peach
midifile (1)
5
2017-07-13
2017-07-13
Antoine Villeret
No

here is a patch that fix 2 issues :

  • first it move the creation of outets before file loading, this avoid a crash (because outlet is used to send data at file loading).
    But it would be better to defer file loading to the next tick to let Pd make connection or use loadbang method to read file in argument.
    Currently if [midifile] is loaded with an argument, file info are send to right outlet but there is no connection so it's a sword strike in the water.

  • then it avoid endless loop in midifile_float(...) metohd by checking positive ticks.

You can find git commit here : https://github.com/avilleret/mrpeach/commits/master

1 Attachments
midifile.patch

Discussion

  • Antoine Villeret

    Antoine Villeret - 2017-07-13
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,8 +1,9 @@
 here is a patch that fix 2 issues : 
+

 - first it move the creation of outets before file loading, this avoid a crash (because outet is used to send data at file loading).
 But it would be better to defer file loading to the next tick to let Pd make connection or use loadbang method to read file in argument.
 Currently if [midifile] is loaded with an argument, file info are send to right outlet but this is no connection already.

-- ten it avoid endless loop in `midifile_float(...)` metohd by checking positive ticks.
+- then it avoid endless loop in `midifile_float(...)` metohd by checking positive ticks.

 You can find git commit here : https://github.com/avilleret/mrpeach/commits/master
     

  • Antoine Villeret

    Antoine Villeret - 2017-07-13
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,8 +1,8 @@
 here is a patch that fix 2 issues : 

-- first it move the creation of outets before file loading, this avoid a crash (because outet is used to send data at file loading).
+- first it move the creation of outets before file loading, this avoid a crash (because outlet is used to send data at file loading).
 But it would be better to defer file loading to the next tick to let Pd make connection or use loadbang method to read file in argument.
-Currently if [midifile] is loaded with an argument, file info are send to right outlet but this is no connection already.
+Currently if [midifile] is loaded with an argument, file info are send to right outlet but there is no connection so it's a sword strike in the water.


 - then it avoid endless loop in `midifile_float(...)` metohd by checking positive ticks.
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB