Menu

#561 declare: don't infect parent abstractions

bugfix
closed-fixed
5
2016-05-11
2015-09-24
No

attached you find two patches:

  • 0001-make-declare-have-an-immediate-effect-in-an-interact.patch

    • this is really the same path as found in #560 (so don't apply it double); it makes [declare] do it's thing when created manually (outside of patch-loading), so the new paths/libs have an immediate effect (no need to re-load the patch to use the declarations)
  • 0002-don-t-save-declare-statements-on-parent-abstractions.patch

  • this one prevents [declare] to infect the parent abstractions. it does so by simply not recursing upwards when it encounters an abstraction (instead of a subpatch)
2 Attachments

Discussion

  • Miller Puckette

    Miller Puckette - 2015-12-29

    i had already done this as prep for the previous patch

     
  • Miller Puckette

    Miller Puckette - 2015-12-29
    • status: open --> pending-fixed
     
  • Anonymous

    Anonymous - 2016-02-24

    Won't 0002 have a downside effect ?
    Currently you can nest a list of [declare]s inside of an abstraction, that you can use as a macro-declare block in application patch. Will this still possible ?
    If not, what would you think of adding a flag to [declare], like "-parent" or "-up", restoring the original behaviour, for this special case?

     
  • IOhannes m zmölnig

    indeed, this "ab(use)" case won't be possible any more.

    otoh, i think it mostly shouldn't be needed as i think this trick is mostly needed to declare sub-dependencies (dependencies within the abstractions) and those abstractions should now declare their dependencies themselves.

    btw, both patches have already been accepted into the mainstream Pd repository (no release yet).

     
  • Antoine Rousseau

    abstractions should now declare their dependencies themselves.

    Ok ; but anyway I found it handy to macro-declare many subdirs then being able to create abs in a simple way (without having to prepend path : [e] instead of [a/b/c/d/e] ). That's not such a big deal but adding this kind of flag "-up" could keep this possible.

    (sorry for previous anonymous posting, didn't see I wasn't logged in...)

     

    Last edit: Antoine Rousseau 2016-02-25
  • IOhannes m zmölnig

    • Status: pending-fixed --> closed-fixed
     

Anonymous
Anonymous

Add attachments
Cancel