#215 cyclone/comment takes part of comment as classname on save

v0.40.2
closed-fixed
5
2015-06-18
2007-11-25
No

When saving a [cyclone/comment] object, the classname is replaced by the first atom in the comment section of that object whenever that patch is saved.

This is probably related to the bug fix for including the namespace prefix when saving.

To reproduce:

- open a new patch
- create a comment object with some text in it
- save and close the patch
- reopen that patch, and voila

Discussion

  • IOhannes m zmölnig

    Logged In: YES
    user_id=564396
    Originator: NO

    btw, it works fine with pd-vanilla 0.41-1

     
  • Hans-Christoph Steiner

    Logged In: YES
    user_id=27104
    Originator: YES

    it probably works fine on 0.41.0 vanilla because I removed the offending code. That means that [cyclone/comment] gets turned into [comment] on save. :( Anyone want to take a stab and getting cyclone to save its namespace prefix?

     
  • Nobody/Anonymous

    I'll take a stab at it:

    1) Add this member to the t_comment struct:
    t_symbol *x_selector;

    2) Add this somewhere at the beginning of comment_new:
    x->x_selector = s;

    3) In comment_list and comment_save, change gensym("comment") to x->x_selector

    4) Voila!

    It's an ugly fix, but comment.c is some ugly code. Time spent fixing it more elegantly would be better spent making a better comment with support for spaces in font names, an iemgui style menu, a sizegrab, etc...

     
  • electrickery

    electrickery - 2015-06-09

    Fixed this with revision 17480 by applying the stab described above.

     
  • electrickery

    electrickery - 2015-06-18
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,3 @@
    -
     When saving a \[cyclone/comment\] object, the classname is replaced by the first atom in the comment section of that object whenever that patch is saved.
    
     This is probably related to the bug fix for including the namespace prefix when saving.
    
    • status: open --> closed-fixed
     
  • electrickery

    electrickery - 2015-06-18

    The anonymously provided patch description worked as expected.

     


Anonymous

Cancel  Add attachments





Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks