Menu

#1262 bendin bug

v0.47
open
None
5
2017-02-09
2016-09-04
Anonymous
No

so, bendout takes from -8192 to 8191, but bendin will receive from 0 to 16383, which is inconsistent with the bendin message, can it be considered a bug and fixed?

cheers

Discussion

  • Albert Graef

    Albert Graef - 2016-10-16

    I think that bendin should deliver values starting at -8192 to be consistent (also makes it easier to map the bends to frequency ratios). This is really easy to fix in x_midi.c. Just for the record, this got fixed in pd-l2ork in rev. 83fbd4f and b64e49c, cf. https://github.com/pd-l2ork/pd/commits/master/pd/src/x_midi.c

    Miller, you might recall that I already bugged you about this a long time ago. :) Unfortunately, I then forgot to follow up with an actual bug report.

     

    Last edit: Albert Graef 2016-10-16
  • Albert Graef

    Albert Graef - 2016-10-16

    Patch against current master and little test patch

     
  • Albert Graef

    Albert Graef - 2017-01-04

    The patch above (x_midi.diff) still applies cleanly, can someone please commit? Thanks.

     
  • Albert Graef

    Albert Graef - 2017-01-17
     
  • Alexandre Porres

    I see that our discussion is leading for this bug not to be fixed, so let's just close this issue

     

Anonymous
Anonymous

Add attachments
Cancel