#1128 still on cartopol~ / poltocar~

v0.43
closed-fixed
None
7
2015-06-09
2013-12-20
Anonymous
No

hi there, I once called for the attention that these objects were buggy, as they were giving inverted values.

Anyway, since they were both screwed up in the same way, the conversion back would inverted back and make everything alright, or at least sound correct.

Well, for the pd extended 0.43 I see this has been corrected, at least for the control data objects.

As for the signal objects, [cartopol~] was corrected, but not [poltocar~]. This means that it now can screw up your sound processing a lot and make some patches - that were actually "ok" before - sound bad.

the way to work around this problem is to invert the imaginary part (multiply it by -1) coming out of [poltocar~]

Cheers

Discussion

  • IOhannes m zmölnig

    do you have a reference to the original bug-report?
    it's hard to tell, which direction is "screwed up" (the mathematically correct notation would be to have the the angle go counterclockwise from X-axis to Y-axis), so xyz={0,1,0} should give you rpz={1,pi/2,0})

     
  • electrickery

    electrickery - 2014-12-13

    With help from the cool patch from Alexandre, it seems clear it is the poltocar~ object. With changing line 35 to: "*out2++ = am * sinf(ph);" the patch worked ok. I will test some more, make a real diff/patch, and submit it to the patch tracker

     
  • electrickery

    electrickery - 2015-06-09

    Fixed with [r17483]

     

    Related

    Commit: [r17483]

  • electrickery

    electrickery - 2015-06-09
    • status: open --> closed-fixed
    • assigned_to: electrickery
     


Anonymous

Cancel  Add attachments