#43 Fix for left shift bug

closed-accepted
None
1
2011-03-10
2011-03-08
No

Attached patch fixes a small bug in uuid_unpack: '>>' has lower precedence than cast to uint8

(Note: this is my first patch! Hope I did it all correctly, if not please let me know!)

Discussion



  • 2011-03-08

    Patch for shift fix

     
    Attachments
    • assigned_to: nobody --> mroberto
    • priority: 5 --> 1
    • status: open --> closed-accepted
     
  • Hi Iain,

    I have accepted your patch.

    Since you asked, there are some problems with it. Usually you use diff in such a way that patch -p1 < your_patch.diff would apply cleanly. In your case I had to do -p3. I also had to convert your files from windows text format to unix text format.

    In order to make all these and other details much simpler, you should be using git. To create a patch, you use "git format-patch" and it does the job for you. Makes it simpler for me to apply them too.

    Regards,
    Marcelo.