#22 Please give option to allow omission of test_url during build
Hi Marcelo,
I see there are some relative URL tests recently added to branch-1.6.x which, according to the comment in upnp/test/test_url.c, will require the build machine to have network connectivity so as to resolve a domain. Please can you add an option to bypass these tests for use of distro builders, because build servers, on Debian at least, are not guaranteed to have network access.
(in fact the tests fail anyway at the moment as domain libupnp.org currently has no DNS records, not even an SOA. The whoisrequest.org history suggests it's been up and down many times over the last few years).
The attached patch is my attempt at implementing this request. It also changes the domain used in the tests from libupnp.org to upnp.org. What I haven't addressed is that, although a few DNS lookups isn't much traffic, it's not really good behaviour to do tests against a domain one does not own; ideally these tests wouldn't require an active domain at all.
Hi Nick,
This is just a test, the builder machine does not have to run it, so your patch is perfectly fine, except for the fact that it breaks the test because libupnp.org does not exist.
Maybe you could add as a configure option the name of the domain on which to perform the test, if the user chooses to enable it? Then substitute it in a config.h header? What do you think?
If it is too much trouble, we can commit your patch like it is, as I said, I have no hard feelings about a test script.
Regards,
Marcelo.
Hi Nick,
What about this issue?
Regards,
Marcelo.