From: Tim H. <tim...@ie...> - 2002-01-11 15:13:49
|
> Just two notes about formatting the C code you write: please set the tab > width to 8 (as in the Python C source); Sure thing. I just noticed this yesterday as some of your code looked wrong untill I realized MSVCC was using a tab width of 4. I think this is fixed now. > and for some reason the files > ere committed to the CVS at SourceForge in such a way that checking them > out produce Windows-like end-of-lines. This is surprising, because they > were not checked in as binary files. (Petru, how did you check them in? > From a Unix machine using Tim's Windows-formatted files?) Should I run something over the code to replace the line endings next time? Or should CVS normally take care of this automatically in the future? -tim |
From: Armin R. <ar...@ul...> - 2002-01-11 16:20:28
|
Hello Tim, On Fri, 11 Jan 2002, Tim Hochberg wrote: > Should I run something over the code to replace the line endings next time? > Or should CVS normally take care of this automatically in the future? The problem was that Petru didn't think about it and committed from Unix with the Windows end of lines; the Windows version of CVS takes care of this. (BTW I've added you to the developpers of Psyco at SourceForge.) Armin |
From: Tim H. <tim...@ie...> - 2002-01-11 16:27:05
|
Hello Armin, One more quick question, do you care whether spaces or tabs is used to indent? -tim > Hello Tim, > > On Fri, 11 Jan 2002, Tim Hochberg wrote: > > Should I run something over the code to replace the line endings next time? > > Or should CVS normally take care of this automatically in the future? > > The problem was that Petru didn't think about it and committed from Unix > with the Windows end of lines; the Windows version of CVS takes care of > this. (BTW I've added you to the developpers of Psyco at SourceForge.) > > > Armin > |
From: Armin R. <ar...@ul...> - 2002-01-11 16:57:32
|
Hello Tim, On Fri, 11 Jan 2002, Tim Hochberg wrote: > One more quick question, do you care whether spaces or tabs is used to > indent? No. I put tabs in half of my files (the ones indented like Python) and spaces in the other half (the ones indented as Emacs does by default). Feel free to use your own indentation style. Please just avoid lines too long. Armin |