Menu

#3 Makefile top-level target canonicalization

Unstable_(example)
closed-accepted
nobody
None
5
2019-02-14
2018-11-08
No

The current makefile mixes the actions of "all", "check" and "clean" in ways that violate my expectations. The attached patch fixes the following problems:

  1. "make ; make" no longer builds the test programs twice
  2. -Werror is no longer the default build: you have to ask for it with "make check-werror"
  3. redundant targets are collected together

All of this is a matter of taste, so I won't be upset if you don't apply this patch entirely. The items are ordered most important first, by my lights.

1 Attachments

Discussion

  • Jonathan Wakely

    Jonathan Wakely - 2018-11-08

    Looks good to me.

     
  • Jonathan Wakely

    Jonathan Wakely - 2019-02-14

    Committed as d7227d867284c6a4cae47fa1b691348394e85728 - thanks!

     
  • Jonathan Wakely

    Jonathan Wakely - 2019-02-14
    • status: open --> closed-accepted
     

Log in to post a comment.