Menu

#453 Circular dependancies in Utils

next release
closed-fixed
nobody
None
5
2021-07-27
2021-07-27
Mike Keith
No

Maybe I'm doing something dumb, but I can't seem to compile psrchive anymore because the Util/genutil library code depends on the Util/fft code so won't build, but also the Util/fft code depends on Util/genutil so if I swap the order of building it also doesn't seem to work.

First it complains of the headers missing - and if I copy the headers to local_include manually then building Utils/fft reports

make: *** No rule to make target `../../Util/genutil/libgenutil.la', needed by `fft_speed'.  Stop.

and similarly a problem looking for libfft.la when linking getMJD if we build genutil first.

make[4]: *** No rule to make target `../../Util/fft/libpsrfft.la', needed by `getMJD'.  Stop.

I think I can get it to work with some trickery... I'll update if I work it out.

Discussion

  • Willem van Straten

    Hi Mike,

    Sorry about that. I fixed this bug somewhere, but I think that I must have done it on a branch.

    I'll merge that branch into the main trunk now ...

    Cheers,
    Willem

     
  • Willem van Straten

    ok. I've merged the branch with the fix (amongst other things) into the main branch and pushed the merged master back to sf git.

     
    👍
    1
  • Mike Keith

    Mike Keith - 2021-07-27

    Awesome, thanks willem, can confirm that this builds ok now!

     
  • Mike Keith

    Mike Keith - 2021-07-27
    • status: open --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB