psmisc / Bugs / #67 [PATCH] Avoid possible crash as well as memory leak in killall

#67 [PATCH] Avoid possible crash as well as memory leak in killall

Milestone: Next Release

Status: closed

Owner: Dr. Werner Fink

Labels: None

Priority: 1

Updated: 2015-06-05

Created: 2015-03-12

Creator: Dr. Werner Fink

Private: No

By reading the current HEAD I stumbled on a memory leak in killall.c as well as on n not assigned pointer got_long in load_proc_cmdline() which may lead to SIGSEGV ... the attached patch may fix this (IMHO). Is this correct?

Werner

1 Attachments

0001-Avoid-possible-crash-as-well-as-memory-leak-in-killa.patch

Discussion

Craig Small - 2015-03-14

Hi Werner,
Yes it looks like it got messed up when i was copying and pasting to shuffle that loop around. I have applied the patch and committed the patch at [05a66f]. I couldn't git am it but it looks ok with the right attributions now.

Related

Commit: [05a66f]

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Craig Small - 2015-03-14

status: open --> closed

assigned_to: Dr. Werner Fink
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous - 2015-06-05

Post awaiting moderation.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous - 2015-06-05

Post awaiting moderation.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous

[PATCH] Avoid possible crash as well as memory leak in killall

Old location for psmisc

Group

Searches

Help

#67 [PATCH] Avoid possible crash as well as memory leak in killall

Discussion

Related