|
From: Kessner, D. E. <Dar...@cs...> - 2008-01-22 16:14:33
|
Hi all, =20 I've collected some notes regarding the mzML spec: =20 1) There are references in the specification document to InstrumentType, SampleType, etc. that I assume mean <instrument> element, <sample> element, etc, though this is not explicitly stated anywhere. =20 2) The <precursor> element has a spectrumRef attribute that is supposed to refer to the id attribute of a <spectrum>. However, the <precursor> element in tiny1.mzML0.99.1.mzML appears to refer to a scanNumber, not id. Which is the intended attribute to reference (I assume 'id')? =20 3) The <cv> element has the attribute fullName=3D"Proteomics Standards Initiative Mass Spectrometry Ontology". This text does not appear in psi-ms.obo - perhaps it should? Basically, I think it would be useful to have some identifier that appears in both psi-ms.obo and in mzML files generated with that psi-ms.obo. Or even better, an id and a version, just like the <softwareParam> elements, but in the psi-ms.obo it could appear in the header. =20 4) Regarding <softwareParam> elements, is there a reason not to use two of the more general <cvParam> elements, one to specify the software, and one to specify the version? =20 5) Element reference naming consistency -- in many cases, there is an element name and a corresponding (either attribute or element) name for a reference to it: =20 <instrument> <-- instrumentRef <sourceFile> <-- sourceFileRef <spectrum> <-- spectrumRef =20 But there are a few exceptions: =20 <referenceableParamGroup> <-- paramGroupRef=20 <software> <-- softwareRef AND instrumentSoftwareRef =20 Suggestions: Replace <referenceableParamGroup> with <paramGroup> Remove <instrumentSoftwareRef> and use <softwareRef> =20 Since the id attribute is usually used for references, we could also have: <cv id=3D"MS" ... > ...=20 <cvParam cvRef=3D"MS" ...> =20 There is also some redundancy in the naming of <sourceFile> attributes: <sourceFile id=3D"1" sourceFileName=3D"tiny1.RAW" sourceFileLocation=3D"file://F:/data/Exp01" > could be shortened to: <sourceFile id=3D"1" name=3D"tiny1.RAW" location=3D"file://F:/data/Exp01"= > =20 =20 =20 Darren =20 =20 =20 Darren Kessner Scientific Programmer Dar...@cs... 310-423-9538 =20 Spielberg Family Center for Applied Proteomics Cedars-Sinai Medical Center http://www.sfcap.cshs.org/ =20 =20 IMPORTANT WARNING: This message is intended for the use of the person or = entity to which it is addressed and may contain information that is privi= leged and confidential, the disclosure of which is governed by applicable law. If the reader of this message is not the intended recipi= ent, or the employee or agent responsible for delivering it to the intend= ed recipient, you are hereby notified that any dissemination, distributio= n or copying of this information is STRICTLY PROHIBITED. If you have received this message in error, please notify us immediately by calling (310) 423-6428 and destroy the related message. Thank You for= your cooperation. |