Menu

#1 filter file parsing and flow control

open
None
5
2004-05-17
2003-08-28
No

I found two bugs in proxy.c (download version 2.2.4):

1) line 269 accomplishes nothing. Furthermore, the CRs
aren't effectively removed. I recommend replacing
lines 266-270 with the following lines:

len = strlen(str);
str[--len] = '\0';
if (str[0] == '#' || 0>=len) continue;

(where len is an int)

2) in the case where a connection is rejected, the
proxy still connects to the destination -- defeating
the purpose of the filter. I recommend adding the
following statement after line 453:

continue;

Discussion

  • Theron Parlin

    Theron Parlin - 2004-05-17
    • assigned_to: nobody --> sparlin
     
  • Theron Parlin

    Theron Parlin - 2004-05-17

    Logged In: YES
    user_id=21256

    Thank you, I will take a look at this...

     

Log in to post a comment.