Kiran,
On Tue, 2004-06-01 at 21:27, Kiran T wrote:
> One solution would be split the existing OnExecute() method into
> OnExecuteStart() and OnExecuteEnd(). If changing an existing public method
> in the Proxool API is a concern, can a new method be added and let the
> existing OnExecute() do the function of either start or end event?
Changing the public API is a concern. And adding additional methods is
not trivial since it would break all implementing classes that,
presumably, wouldn't implement that method.
However, your suggestion is a good one. Especially since in some trouble
shooting scenarios an afterExecute() might happen a long time after a
beforeExecute().
> If this is something that can be rolled out to 1.0, is there a temporary
> solution to tackle this issue?
The onExecute already contains the execution time.
http://proxool.sourceforge.net/api/org/logicalcobwebs/proxool/ConnectionListenerIF.html#onExecute(java.lang.String,%20long)
public void onExecute(java.lang.String command, long elapsedTime)
Happens after every successful execute. Note that the command is not
fully implemented at this stage. At some point it might represent the
SQL that is sent to the database (or the procedure call that was used).
Parameters:
command - what command was being executed
elapsedTime - how long the call took (in milliseconds)
Would that help?
- Bill
|