proxool-developer

[Proxool-developer] Connection Equality

[Bill H. <bi...@lo...>]

Hi all,

I'm coding the disposable wrappers just now. And I just wanted to run
some behaviour past everyone.

Connection c1 = DriverManager.getConnection(url);
c1.close();

Connection c2 = DriverManager.getConnection(url);
c2.close();

// This test will ALWAYS be false, even if the actual
// underlying connection is the same
if (c1.equals(c2)) {
  // Never true!
}

Instinctively, this behaviour most closely matches the behaviour you'd
experience if you didn't have a pool at all.

However, I wonder whether it will cause problems with some systems.
Christian, some of your/my code relies on being able to identify the
same connection being used in a Map doesn't it? Any thoughts?

Note: I can code it either way. I'm just trying to work out which is the
sanest. The current (0.8.3) behaviour (because there are no disposable
wrappers) is:

if (c1.equals(c2)) {
  // True if, by coincidence, you get the same underlying 
  // connection back
}

- Bill

Re: [Proxool-developer] Connection Equality

[Craig S. <cs...@cr...>]

On Tuesday 18 May 2004 15:56, Bill Horsman wrote:
> However, I wonder whether it will cause problems with some systems.
> Christian, some of your/my code relies on being able to identify the
> same connection being used in a Map doesn't it? Any thoughts?

It is a little bit strange to have equals() guarantee that it is the same 
connection.  I usually count on equals() to tell me something about logical 
equality and == to see if something is really the same object.

for example:
      Date d1 = new Date();
      Date d2 = (Date) d1.clone();

      if ( d1.equals( d2 ) ) {

         // This is true
      }

      if ( d1 == d2  ) {

         // This is not
      }


This make it seem as though two connections should be equal if they come from 
the same pool and have the same state.  Since if they came from the same pool 
they would have all of the same logical properties.

Just my $.02,

Craig
-- 
In theory, practice and theory are the same, but in practice they are 
different
GPG Public Key https://www.cromagnon.com/ssl/craigkey.gpg