Apologies for the fomat being screwy, but I'm not familiar with CVS or diff.
Thanks!
-john.
$ diff -c1 ConnectionPool.java_old ConnectionPool.java
*** ConnectionPool.java_old Tue Dec 9 08:54:24 2003
--- ConnectionPool.java Tue Dec 9 09:05:56 2003
***************
*** 287,292 ****
} finally {
! try {
! s.close();
! } catch (SQLException e) {
! // Ignore
}
--- 287,294 ----
} finally {
! if( s!=null ) {
! try {
! s.close();
! } catch (SQLException e) {
! // Ignore
! }
}
-----Original Message-----
From: Bill Horsman [mailto:bi...@lo...]
Sent: Tuesday, December 09, 2003 3:51 AM
To: Hume, John - NA US HQ Delray
Cc: 'Pro...@li...'
Subject: Re: [Proxool-developer] finally block throws NPE
Hi John,
On Mon, 2003-12-08 at 21:58, Hume, John - NA US HQ Delray wrote:
> I added "if(s!=null)" to the beginning of line 288 to get around this.
Let
> me know if you'd like me to submit this as a bug and/or patch on
> sourceforge. Thanks.
Thanks for the contribution. Yes please, either submit a patch on
sourceforge or just email me the diff and I will be happy to incorporate
the fix into our next release (which isn't that far away).
Regards,
Bill Horsman
|
