Re: [Proxool-developer] Allow empty values in ProxoolDataSource.setDelegateProperties()

[Tom D. <td...@te...>]

Hi Bill,

On Dec 14, 2007, at 7:53 AM, Bill Horsman wrote:

> Yes, that makes sense. I've just submitted a change to  
> ProxoolDataSource
> to do that:
>
>  if (stInner.countTokens() == 1) {
>    // Allow blank string to be a valid value
>    delegateProperties.put(stInner.nextToken().trim(), "");
>  } else if (stInner.countTokens() == 2) {
>    delegateProperties.put(stInner.nextToken().trim(),
> stInner.nextToken().trim());
>  } else {
>    throw new IllegalArgumentException("Unexpected delegateProperties
> value: '" + properties + "'. Expected 'name=value'");
>  }
>
> Would you like to check out a copy of Proxool from CVS and give it a  
> whirl?

Works great except I had to change line 328 of ProxoolDataSource.java  
from:

     public void setMaximumActiveTime(int maximumActiveTime) {

to:

     public void setMaximumActiveTime(long maximumActiveTime) {

Otherwise, Spring complains about some type conversion.  Funnily  
enough, I don't even need the change to setDelegateProperties() with  
this version thanks to the fix in 1.8.  Any idea when the next release  
will happen, RC or otherwise?

Tom

> On 12/13/2007 03:27 PM, Tom Duffey wrote:
>> Hi All,
>>
>> Wondering if we could patch
>> ProxoolDataSource.setDelegateProperties(String) to allow specifying
>> properties with no value?  In other words, I would like to be able
>> to do something like:
>>
>> dataSource.setDelegateProperties("username=foo, password=")
>>
>> Currently this throws an exception but I think it should be allowed
>> and simply ignore the name/value pair when the value is empty.
>>
>> Regards,
>>
>> Tom
>>
>> -------------------------------------------------------------------------
>> SF.Net email is sponsored by: Check out the new SourceForge.net
>> Marketplace. It's the best place to buy or sell services for just
>> about anything Open Source.
>>
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
>> _______________________________________________ Proxool-developer
>> mailing list Pro...@li...
>> https://lists.sourceforge.net/lists/listinfo/proxool-developer
>
> -------------------------------------------------------------------------
> SF.Net email is sponsored by:
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services
> for just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> Proxool-developer mailing list
> Pro...@li...
> https://lists.sourceforge.net/lists/listinfo/proxool-developer