From: Bill H. <bi...@lo...> - 2005-10-07 10:17:54
|
Hi all, I'm considering unbundling commons-logging from the upcoming release of Proxool 0.9.0. I had some class loader issues when I tried to deployed the latest code into Tomcat 5.5 and switching to the external commons-logging was the only option. For the record, we copied the commons-logging 1.02 code into Proxool in February 2003 for Proxool 0.7. We created a new package called org.logicalcobwebs.logging. We did this along with a couple other components: cglib and asm. The case for cglib and asm is a good one since changes they made to the code could break Proxool and we didn't want to have to make emergency releases of Proxool to keep in step with cglib and asm. But commons-logging is unlikely to break Proxool I feel and the only benefit we get is not having to have that dependency. However, there are some serious drawbacks to bundling our own version of commons-logging: 1. There is a class loader problem in some situationns. 2. Logging is often done by the container or by the application and problems arise if Proxool is logging to some classes whilst other code is logging elsewhere. So I'm proposing that we remove the commons-logging code from Proxool and list commons-logging as a dependency. Any comments? - Bill |